services/ui/gpu/display_compositor/compositor_frame_sink_factory_impl.cc - Issue 2326913003: Privatize StrongBinding lifetime management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: services/ui/gpu/display_compositor/compositor_frame_sink_factory_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « services/ui/gpu/display_compositor/compositor_frame_sink_factory_impl.h ('k') | services/ui/gpu/display_compositor/display_compositor_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: services/ui/gpu/display_compositor/compositor_frame_sink_factory_impl.cc

diff --git a/services/ui/gpu/display_compositor/compositor_frame_sink_factory_impl.cc b/services/ui/gpu/display_compositor/compositor_frame_sink_factory_impl.cc

index 1dea3d0811217a7c69a6e1639d847b575b0b4b21..589de5ecda805aa7e19644b4af4c73efe774d592 100644

--- a/services/ui/gpu/display_compositor/compositor_frame_sink_factory_impl.cc

+++ b/services/ui/gpu/display_compositor/compositor_frame_sink_factory_impl.cc

@@ -13,12 +13,10 @@ namespace gpu {

CompositorFrameSinkFactoryImpl::CompositorFrameSinkFactoryImpl(

uint32_t client_id,

- mojo::InterfaceRequest<mojom::CompositorFrameSinkFactory> request,

const scoped_refptr<SurfacesState>& surfaces_state)

: client_id_(client_id),

surfaces_state_(surfaces_state),

- allocator_(client_id),

- binding_(this, std::move(request)) {}

+ allocator_(client_id) {}

CompositorFrameSinkFactoryImpl::~CompositorFrameSinkFactoryImpl() {}