Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(440)

Unified Diff: services/navigation/view_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « services/navigation/navigation.cc ('k') | services/navigation/view_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: services/navigation/view_impl.h
diff --git a/services/navigation/view_impl.h b/services/navigation/view_impl.h
index 0f4199c4273785a21678e3463e7ab74c130865df..8d9c5d2316b570670b7c481cda12ec6edf2baa81 100644
--- a/services/navigation/view_impl.h
+++ b/services/navigation/view_impl.h
@@ -12,7 +12,6 @@
#include "content/public/browser/notification_registrar.h"
#include "content/public/browser/web_contents_delegate.h"
#include "mojo/public/cpp/bindings/binding_set.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
#include "services/navigation/public/interfaces/view.mojom.h"
#include "services/shell/public/cpp/interface_factory.h"
#include "services/shell/public/cpp/service.h"
@@ -37,7 +36,6 @@ class ViewImpl : public mojom::View,
ViewImpl(std::unique_ptr<shell::Connector> connector,
const std::string& client_user_id,
mojom::ViewClientPtr client,
- mojom::ViewRequest request,
std::unique_ptr<shell::ServiceContextRef> ref);
~ViewImpl() override;
@@ -92,7 +90,6 @@ class ViewImpl : public mojom::View,
const views::Widget* GetWidget() const override;
std::unique_ptr<shell::Connector> connector_;
- mojo::StrongBinding<mojom::View> binding_;
mojom::ViewClientPtr client_;
std::unique_ptr<shell::ServiceContextRef> ref_;
« no previous file with comments | « services/navigation/navigation.cc ('k') | services/navigation/view_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698