Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(164)

Unified Diff: net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/mojo_proxy_resolver_factory_impl.cc ('k') | services/catalog/catalog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc
diff --git a/net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc b/net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc
index 65b315107f53914181979c1d0794f9406137bea7..2d95eec291015a8dd71a16f1f2039776c5930ecb 100644
--- a/net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc
+++ b/net/proxy/mojo_proxy_resolver_factory_impl_unittest.cc
@@ -9,6 +9,7 @@
#include "base/memory/ptr_util.h"
#include "base/strings/utf_string_conversions.h"
#include "mojo/public/cpp/bindings/binding.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
#include "net/base/test_completion_callback.h"
#include "net/proxy/mock_proxy_resolver.h"
#include "net/proxy/proxy_resolver_v8_tracing.h"
@@ -104,8 +105,9 @@ class MojoProxyResolverFactoryImplTest
public:
void SetUp() override {
mock_factory_ = new TestProxyResolverFactory(&waiter_);
- new MojoProxyResolverFactoryImpl(base::WrapUnique(mock_factory_),
- mojo::GetProxy(&factory_));
+ mojo::MakeStrongBinding(base::MakeUnique<MojoProxyResolverFactoryImpl>(
+ base::WrapUnique(mock_factory_)),
+ mojo::GetProxy(&factory_));
}
void OnConnectionError() { waiter_.NotifyEvent(CONNECTION_ERROR); }
« no previous file with comments | « net/proxy/mojo_proxy_resolver_factory_impl.cc ('k') | services/catalog/catalog.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698