Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(126)

Unified Diff: net/proxy/mojo_proxy_resolver_factory_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/proxy/in_process_mojo_proxy_resolver_factory.cc ('k') | net/proxy/mojo_proxy_resolver_factory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/proxy/mojo_proxy_resolver_factory_impl.h
diff --git a/net/proxy/mojo_proxy_resolver_factory_impl.h b/net/proxy/mojo_proxy_resolver_factory_impl.h
index e305e47fd4a27c3e9e1aba6c2535e51e9cb57bba..32cb9b09d5bc8a6fe01f320b7066151f0bfdf780 100644
--- a/net/proxy/mojo_proxy_resolver_factory_impl.h
+++ b/net/proxy/mojo_proxy_resolver_factory_impl.h
@@ -9,7 +9,6 @@
#include "base/callback.h"
#include "base/macros.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
#include "net/interfaces/proxy_resolver_service.mojom.h"
namespace net {
@@ -19,11 +18,9 @@ class ProxyResolverV8TracingFactory;
class MojoProxyResolverFactoryImpl : public interfaces::ProxyResolverFactory {
public:
+ MojoProxyResolverFactoryImpl();
explicit MojoProxyResolverFactoryImpl(
- mojo::InterfaceRequest<interfaces::ProxyResolverFactory> request);
- MojoProxyResolverFactoryImpl(
- std::unique_ptr<ProxyResolverV8TracingFactory> proxy_resolver_factory,
- mojo::InterfaceRequest<interfaces::ProxyResolverFactory> request);
+ std::unique_ptr<ProxyResolverV8TracingFactory> proxy_resolver_factory);
~MojoProxyResolverFactoryImpl() override;
@@ -33,14 +30,13 @@ class MojoProxyResolverFactoryImpl : public interfaces::ProxyResolverFactory {
// interfaces::ProxyResolverFactory override.
void CreateResolver(
const mojo::String& pac_script,
- mojo::InterfaceRequest<interfaces::ProxyResolver> request,
+ interfaces::ProxyResolverRequest request,
interfaces::ProxyResolverFactoryRequestClientPtr client) override;
void RemoveJob(Job* job);
const std::unique_ptr<ProxyResolverV8TracingFactory>
proxy_resolver_impl_factory_;
- mojo::StrongBinding<interfaces::ProxyResolverFactory> binding_;
std::set<Job*> jobs_;
« no previous file with comments | « net/proxy/in_process_mojo_proxy_resolver_factory.cc ('k') | net/proxy/mojo_proxy_resolver_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698