Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: media/mojo/services/service_factory_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_video_decoder_service.cc ('k') | media/mojo/services/service_factory_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/service_factory_impl.h
diff --git a/media/mojo/services/service_factory_impl.h b/media/mojo/services/service_factory_impl.h
index 5407b910eaa30c4291991d2ec9a3a8e72202ab6b..9df6b6ab281eea0b1700075ecc90ae12d38db450 100644
--- a/media/mojo/services/service_factory_impl.h
+++ b/media/mojo/services/service_factory_impl.h
@@ -10,7 +10,6 @@
#include "base/macros.h"
#include "media/mojo/interfaces/service_factory.mojom.h"
#include "media/mojo/services/mojo_cdm_service_context.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
#include "services/shell/public/cpp/connector.h"
#include "services/shell/public/cpp/service_context_ref.h"
@@ -29,8 +28,7 @@ class RendererFactory;
class ServiceFactoryImpl : public mojom::ServiceFactory {
public:
- ServiceFactoryImpl(mojo::InterfaceRequest<mojom::ServiceFactory> request,
- shell::mojom::InterfaceProviderPtr interfaces,
+ ServiceFactoryImpl(shell::mojom::InterfaceProviderPtr interfaces,
scoped_refptr<MediaLog> media_log,
std::unique_ptr<shell::ServiceContextRef> connection_ref,
MojoMediaClient* mojo_media_client);
@@ -53,7 +51,6 @@ class ServiceFactoryImpl : public mojom::ServiceFactory {
#endif // defined(ENABLE_MOJO_CDM)
MojoCdmServiceContext cdm_service_context_;
- mojo::StrongBinding<mojom::ServiceFactory> binding_;
#if defined(ENABLE_MOJO_RENDERER)
std::unique_ptr<RendererFactory> renderer_factory_;
« no previous file with comments | « media/mojo/services/mojo_video_decoder_service.cc ('k') | media/mojo/services/service_factory_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698