Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(815)

Unified Diff: media/mojo/services/mojo_video_decoder_service.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_renderer_service.cc ('k') | media/mojo/services/mojo_video_decoder_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_video_decoder_service.h
diff --git a/media/mojo/services/mojo_video_decoder_service.h b/media/mojo/services/mojo_video_decoder_service.h
index f0338ce2eddc9992797489e3390ce30ac7759bce..bf1449f38d2b58db9436d8daba03f01ea0c180ca 100644
--- a/media/mojo/services/mojo_video_decoder_service.h
+++ b/media/mojo/services/mojo_video_decoder_service.h
@@ -11,7 +11,6 @@
#include "base/memory/weak_ptr.h"
#include "media/base/decode_status.h"
#include "media/mojo/interfaces/video_decoder.mojom.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace media {
@@ -24,8 +23,7 @@ class VideoFrame;
// and wraps a media::VideoDecoder.
class MojoVideoDecoderService : public mojom::VideoDecoder {
public:
- MojoVideoDecoderService(mojo::InterfaceRequest<mojom::VideoDecoder> request,
- MojoMediaClient* mojo_media_client);
+ explicit MojoVideoDecoderService(MojoMediaClient* mojo_media_client);
~MojoVideoDecoderService() final;
// mojom::VideoDecoder implementation
@@ -44,7 +42,6 @@ class MojoVideoDecoderService : public mojom::VideoDecoder {
void OnDecoderOutput(const scoped_refptr<VideoFrame>& frame);
void OnDecoderReset(const ResetCallback& callback);
- mojo::StrongBinding<mojom::VideoDecoder> binding_;
mojom::VideoDecoderClientPtr client_;
std::unique_ptr<MojoDecoderBufferReader> mojo_decoder_buffer_reader_;
« no previous file with comments | « media/mojo/services/mojo_renderer_service.cc ('k') | media/mojo/services/mojo_video_decoder_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698