Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1617)

Unified Diff: media/mojo/services/mojo_renderer_service.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_media_application.cc ('k') | media/mojo/services/mojo_renderer_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_renderer_service.h
diff --git a/media/mojo/services/mojo_renderer_service.h b/media/mojo/services/mojo_renderer_service.h
index a99d61da1ccf1d135b2bb6d3544bd29ccd42c905..68e0dee5c3afc82de3b51f416056efed4df6b43c 100644
--- a/media/mojo/services/mojo_renderer_service.h
+++ b/media/mojo/services/mojo_renderer_service.h
@@ -20,7 +20,6 @@
#include "media/base/renderer_client.h"
#include "media/mojo/interfaces/renderer.mojom.h"
#include "media/mojo/services/media_mojo_export.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace media {
@@ -43,8 +42,7 @@ class MEDIA_MOJO_EXPORT MojoRendererService
base::WeakPtr<MojoCdmServiceContext> mojo_cdm_service_context,
scoped_refptr<AudioRendererSink> audio_sink,
std::unique_ptr<VideoRendererSink> video_sink,
- std::unique_ptr<media::Renderer> renderer,
- mojo::InterfaceRequest<mojom::Renderer> request);
+ std::unique_ptr<media::Renderer> renderer);
~MojoRendererService() final;
// mojom::Renderer implementation.
@@ -102,8 +100,6 @@ class MEDIA_MOJO_EXPORT MojoRendererService
const base::Callback<void(bool)>& callback,
bool success);
- mojo::StrongBinding<mojom::Renderer> binding_;
-
base::WeakPtr<MojoCdmServiceContext> mojo_cdm_service_context_;
State state_;
« no previous file with comments | « media/mojo/services/mojo_media_application.cc ('k') | media/mojo/services/mojo_renderer_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698