Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1252)

Unified Diff: media/mojo/services/mojo_media_application.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/services/mojo_cdm_service.cc ('k') | media/mojo/services/mojo_renderer_service.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_media_application.cc
diff --git a/media/mojo/services/mojo_media_application.cc b/media/mojo/services/mojo_media_application.cc
index 8c2ea41e1d5a1d297d38e9ff489a3c8f6fa619fa..8295c819d28f617b987270d9e4af4d793b35c160 100644
--- a/media/mojo/services/mojo_media_application.cc
+++ b/media/mojo/services/mojo_media_application.cc
@@ -9,6 +9,7 @@
#include "media/base/media_log.h"
#include "media/mojo/services/mojo_media_client.h"
#include "media/mojo/services/service_factory_impl.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
#include "services/shell/public/cpp/connection.h"
#include "services/shell/public/cpp/connector.h"
@@ -53,10 +54,11 @@ void MojoMediaApplication::CreateServiceFactory(
if (!mojo_media_client_)
return;
- // The created object is owned by the pipe.
- new ServiceFactoryImpl(std::move(request), std::move(remote_interfaces),
- media_log_, ref_factory_.CreateRef(),
- mojo_media_client_.get());
+ mojo::MakeStrongBinding(
+ base::MakeUnique<ServiceFactoryImpl>(std::move(remote_interfaces),
+ media_log_, ref_factory_.CreateRef(),
+ mojo_media_client_.get()),
+ std::move(request));
}
} // namespace media
« no previous file with comments | « media/mojo/services/mojo_cdm_service.cc ('k') | media/mojo/services/mojo_renderer_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698