Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: media/mojo/services/mojo_audio_decoder_service.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « media/mojo/clients/mojo_renderer_unittest.cc ('k') | media/mojo/services/mojo_audio_decoder_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: media/mojo/services/mojo_audio_decoder_service.h
diff --git a/media/mojo/services/mojo_audio_decoder_service.h b/media/mojo/services/mojo_audio_decoder_service.h
index d1462802e75defd5be1595b2079c842d7c0720e1..04e998ab55a3a93eebed772c5806d894fe63bdd8 100644
--- a/media/mojo/services/mojo_audio_decoder_service.h
+++ b/media/mojo/services/mojo_audio_decoder_service.h
@@ -13,7 +13,6 @@
#include "base/memory/weak_ptr.h"
#include "media/base/audio_decoder.h"
#include "media/mojo/interfaces/audio_decoder.mojom.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace media {
@@ -25,8 +24,7 @@ class MojoAudioDecoderService : public mojom::AudioDecoder {
public:
MojoAudioDecoderService(
base::WeakPtr<MojoCdmServiceContext> mojo_cdm_service_context,
- std::unique_ptr<media::AudioDecoder> decoder,
- mojo::InterfaceRequest<mojom::AudioDecoder> request);
+ std::unique_ptr<media::AudioDecoder> decoder);
~MojoAudioDecoderService() final;
@@ -59,10 +57,6 @@ class MojoAudioDecoderService : public mojom::AudioDecoder {
// Called by |decoder_| for each decoded buffer.
void OnAudioBufferReady(const scoped_refptr<AudioBuffer>& audio_buffer);
- // A binding represents the association between the service and the
- // communication channel, i.e. the pipe.
- mojo::StrongBinding<mojom::AudioDecoder> binding_;
-
std::unique_ptr<MojoDecoderBufferReader> mojo_decoder_buffer_reader_;
// A helper object required to get CDM from CDM id.
« no previous file with comments | « media/mojo/clients/mojo_renderer_unittest.cc ('k') | media/mojo/services/mojo_audio_decoder_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698