Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Unified Diff: extensions/renderer/api/serial/serial_api_unittest.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « extensions/browser/mojo/stash_backend.cc ('k') | extensions/renderer/mojo/keep_alive_client_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/renderer/api/serial/serial_api_unittest.cc
diff --git a/extensions/renderer/api/serial/serial_api_unittest.cc b/extensions/renderer/api/serial/serial_api_unittest.cc
index fcb1bd44b4b1b97b3e4b1fa3b6f625cb1dcf82c0..04fabf046ee6a99d91b96eb2762b2e1b9c316d17 100644
--- a/extensions/renderer/api/serial/serial_api_unittest.cc
+++ b/extensions/renderer/api/serial/serial_api_unittest.cc
@@ -8,6 +8,7 @@
#include <utility>
#include "base/macros.h"
+#include "base/memory/ptr_util.h"
#include "base/threading/thread_task_runner_handle.h"
#include "device/serial/serial_device_enumerator.h"
#include "device/serial/serial_service_impl.h"
@@ -16,6 +17,7 @@
#include "extensions/common/mojo/keep_alive.mojom.h"
#include "extensions/renderer/api_test_base.h"
#include "grit/extensions_renderer_resources.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
// A test launcher for tests for the serial API defined in
// extensions/test/data/serial_unittest.js. Each C++ test function sets up a
@@ -434,13 +436,13 @@ class SerialApiTest : public ApiTestBase {
void CreateSerialService(
mojo::InterfaceRequest<device::serial::SerialService> request) {
- new device::SerialServiceImpl(
- new device::SerialConnectionFactory(
- base::Bind(&SerialApiTest::GetIoHandler, base::Unretained(this)),
- base::ThreadTaskRunnerHandle::Get()),
- std::unique_ptr<device::SerialDeviceEnumerator>(
- new FakeSerialDeviceEnumerator),
- std::move(request));
+ mojo::MakeStrongBinding(base::MakeUnique<device::SerialServiceImpl>(
+ new device::SerialConnectionFactory(
+ base::Bind(&SerialApiTest::GetIoHandler,
+ base::Unretained(this)),
+ base::ThreadTaskRunnerHandle::Get()),
+ base::MakeUnique<FakeSerialDeviceEnumerator>()),
+ std::move(request));
}
DISALLOW_COPY_AND_ASSIGN(SerialApiTest);
« no previous file with comments | « extensions/browser/mojo/stash_backend.cc ('k') | extensions/renderer/mojo/keep_alive_client_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698