Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc
diff --git a/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc b/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc
index 203caa93b12cb97a0ebcd6bfdff9d26fed4cdede..c6c63bdc3c4881acae65c672607098bd279a1f2c 100644
--- a/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc
+++ b/extensions/browser/api/display_source/wifi_display/wifi_display_media_service_impl.cc
@@ -9,6 +9,7 @@
#include "base/big_endian.h"
#include "content/public/browser/browser_thread.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
#include "net/base/net_errors.h"
using content::BrowserThread;
@@ -41,7 +42,8 @@ WiFiDisplayMediaServiceImpl::PacketIOBuffer::~PacketIOBuffer() {
void WiFiDisplayMediaServiceImpl::Create(
WiFiDisplayMediaServiceRequest request) {
DCHECK_CURRENTLY_ON(content::BrowserThread::IO);
- new WiFiDisplayMediaServiceImpl(std::move(request));
+ mojo::MakeStrongBinding(base::MakeUnique<WiFiDisplayMediaServiceImpl>(),
+ std::move(request));
}
// static
@@ -54,9 +56,7 @@ void WiFiDisplayMediaServiceImpl::BindToRequest(
WiFiDisplayMediaServiceImpl::WiFiDisplayMediaServiceImpl(
WiFiDisplayMediaServiceRequest request)
- : binding_(this, std::move(request)),
- last_send_code_(net::OK),
- weak_factory_(this) {}
+ : last_send_code_(net::OK), weak_factory_(this) {}
WiFiDisplayMediaServiceImpl::~WiFiDisplayMediaServiceImpl() {}

Powered by Google App Engine
This is Rietveld 408576698