Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Unified Diff: device/usb/mojo/device_manager_impl_unittest.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/usb/mojo/device_manager_impl.cc ('k') | device/vibration/vibration_manager_impl_default.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/mojo/device_manager_impl_unittest.cc
diff --git a/device/usb/mojo/device_manager_impl_unittest.cc b/device/usb/mojo/device_manager_impl_unittest.cc
index 4987fe73bdffc7ee070c19725e0dafdafc048e50..611237d4a01b6c875154001d8e45f48d8d692d9d 100644
--- a/device/usb/mojo/device_manager_impl_unittest.cc
+++ b/device/usb/mojo/device_manager_impl_unittest.cc
@@ -23,6 +23,7 @@
#include "device/usb/mock_usb_service.h"
#include "device/usb/mojo/device_impl.h"
#include "device/usb/mojo/mock_permission_provider.h"
+#include "mojo/public/cpp/bindings/binding.h"
#include "testing/gtest/include/gtest/gtest.h"
using ::testing::Invoke;
@@ -62,11 +63,11 @@ class USBDeviceManagerImplTest : public testing::Test {
class MockDeviceManagerClient : public DeviceManagerClient {
public:
- MockDeviceManagerClient() : m_binding(this) {}
+ MockDeviceManagerClient() : binding_(this) {}
~MockDeviceManagerClient() {}
DeviceManagerClientPtr CreateInterfacePtrAndBind() {
- return m_binding.CreateInterfacePtrAndBind();
+ return binding_.CreateInterfacePtrAndBind();
}
MOCK_METHOD1(DoOnDeviceAdded, void(DeviceInfo*));
@@ -80,7 +81,7 @@ class MockDeviceManagerClient : public DeviceManagerClient {
}
private:
- mojo::Binding<DeviceManagerClient> m_binding;
+ mojo::Binding<DeviceManagerClient> binding_;
};
void ExpectDevicesAndThen(const std::set<std::string>& expected_guids,
« no previous file with comments | « device/usb/mojo/device_manager_impl.cc ('k') | device/vibration/vibration_manager_impl_default.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698