Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(427)

Unified Diff: device/usb/mojo/device_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « device/serial/serial_service_unittest.cc ('k') | device/usb/mojo/device_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: device/usb/mojo/device_impl.h
diff --git a/device/usb/mojo/device_impl.h b/device/usb/mojo/device_impl.h
index 8ec722a478b916fde68a75f75358deedd2c305bc..493a98c306f247ddf4333c9ee6c98daf0291432a 100644
--- a/device/usb/mojo/device_impl.h
+++ b/device/usb/mojo/device_impl.h
@@ -17,8 +17,8 @@
#include "device/usb/public/interfaces/device.mojom.h"
#include "device/usb/usb_device.h"
#include "device/usb/usb_device_handle.h"
+#include "mojo/public/cpp/bindings/binding.h"
#include "mojo/public/cpp/bindings/interface_request.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace net {
class IOBuffer;
@@ -37,7 +37,7 @@ class DeviceImpl : public Device, public device::UsbDevice::Observer {
DeviceImpl(scoped_refptr<UsbDevice> device,
DeviceInfoPtr device_info,
base::WeakPtr<PermissionProvider> permission_provider,
- mojo::InterfaceRequest<Device> request);
+ DeviceRequest request);
~DeviceImpl() override;
private:
@@ -110,7 +110,7 @@ class DeviceImpl : public Device, public device::UsbDevice::Observer {
// has been closed.
scoped_refptr<UsbDeviceHandle> device_handle_;
- mojo::StrongBinding<Device> binding_;
+ mojo::Binding<Device> binding_;
base::WeakPtrFactory<DeviceImpl> weak_factory_;
DISALLOW_COPY_AND_ASSIGN(DeviceImpl);
« no previous file with comments | « device/serial/serial_service_unittest.cc ('k') | device/usb/mojo/device_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698