Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(148)

Unified Diff: content/renderer/image_downloader/image_downloader_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/renderer/image_downloader/image_downloader_impl.h ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/image_downloader/image_downloader_impl.cc
diff --git a/content/renderer/image_downloader/image_downloader_impl.cc b/content/renderer/image_downloader/image_downloader_impl.cc
index 5cb89edfb2a59ae55b4cdc8194bdfcfd6c9626ac..a7679900966e61f80eedefda12fd1f9fe4c42cdd 100644
--- a/content/renderer/image_downloader/image_downloader_impl.cc
+++ b/content/renderer/image_downloader/image_downloader_impl.cc
@@ -123,10 +123,13 @@ namespace content {
ImageDownloaderImpl::ImageDownloaderImpl(
RenderFrame* render_frame,
- mojo::InterfaceRequest<content::mojom::ImageDownloader> request)
- : RenderFrameObserver(render_frame), binding_(this, std::move(request)) {
+ mojom::ImageDownloaderRequest request)
+ : RenderFrameObserver(render_frame),
+ binding_(this, std::move(request)) {
DCHECK(render_frame);
RenderThread::Get()->AddObserver(this);
+ binding_.set_connection_error_handler(
+ base::Bind(&ImageDownloaderImpl::OnDestruct, base::Unretained(this)));
}
ImageDownloaderImpl::~ImageDownloaderImpl() {
@@ -141,10 +144,11 @@ ImageDownloaderImpl::~ImageDownloaderImpl() {
// static
void ImageDownloaderImpl::CreateMojoService(
RenderFrame* render_frame,
- mojo::InterfaceRequest<content::mojom::ImageDownloader> request) {
- DVLOG(1) << "ImageDownloaderImpl::CreateService";
+ mojom::ImageDownloaderRequest request) {
+ DVLOG(1) << "ImageDownloaderImpl::CreateMojoService";
DCHECK(render_frame);
+ // Owns itself.
new ImageDownloaderImpl(render_frame, std::move(request));
}
« no previous file with comments | « content/renderer/image_downloader/image_downloader_impl.h ('k') | content/renderer/render_thread_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698