Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: content/browser/service_worker/service_worker_version_unittest.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_version_unittest.cc
diff --git a/content/browser/service_worker/service_worker_version_unittest.cc b/content/browser/service_worker/service_worker_version_unittest.cc
index 1439251b6edade504d6cd5ad40f7b79747a3724e..e42bc901bee6c59e4ec38487931b2c35ba34d154 100644
--- a/content/browser/service_worker/service_worker_version_unittest.cc
+++ b/content/browser/service_worker/service_worker_version_unittest.cc
@@ -163,7 +163,8 @@ base::Time GetYesterday() {
class TestMojoServiceImpl : public mojom::TestMojoService {
public:
static void Create(mojo::InterfaceRequest<mojom::TestMojoService> request) {
- new TestMojoServiceImpl(std::move(request));
+ mojo::MakeStrongBinding(base::WrapUnique(new TestMojoServiceImpl),
+ std::move(request));
}
void DoSomething(const DoSomethingCallback& callback) override {
@@ -183,11 +184,7 @@ class TestMojoServiceImpl : public mojom::TestMojoService {
}
private:
- explicit TestMojoServiceImpl(
- mojo::InterfaceRequest<mojom::TestMojoService> request)
- : binding_(this, std::move(request)) {}
-
- mojo::StrongBinding<mojom::TestMojoService> binding_;
+ explicit TestMojoServiceImpl() {}
};
} // namespace
« no previous file with comments | « content/browser/service_worker/embedded_worker_test_helper.cc ('k') | content/browser/vibration_browsertest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698