Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1476)

Unified Diff: content/browser/renderer_host/offscreen_canvas_frame_receiver_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/offscreen_canvas_frame_receiver_impl.cc
diff --git a/content/browser/renderer_host/offscreen_canvas_frame_receiver_impl.cc b/content/browser/renderer_host/offscreen_canvas_frame_receiver_impl.cc
index 7486aa2993a7c0fb1cc4bec87e82c8d917c5ed26..7e9a204d848070fb259c7b8b2eef7b9eb9dedc90 100644
--- a/content/browser/renderer_host/offscreen_canvas_frame_receiver_impl.cc
+++ b/content/browser/renderer_host/offscreen_canvas_frame_receiver_impl.cc
@@ -7,23 +7,21 @@
#include "cc/surfaces/surface.h"
#include "cc/surfaces/surface_manager.h"
#include "content/browser/compositor/surface_utils.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
namespace content {
+OffscreenCanvasFrameReceiverImpl::OffscreenCanvasFrameReceiverImpl() {}
+
+OffscreenCanvasFrameReceiverImpl::~OffscreenCanvasFrameReceiverImpl() {}
+
// static
void OffscreenCanvasFrameReceiverImpl::Create(
- mojo::InterfaceRequest<blink::mojom::OffscreenCanvasFrameReceiver>
- request) {
- // |binding_| will take ownership of OffscreenCanvasFrameReceiverImpl
- new OffscreenCanvasFrameReceiverImpl(std::move(request));
+ blink::mojom::OffscreenCanvasFrameReceiverRequest request) {
+ mojo::MakeStrongBinding(base::MakeUnique<OffscreenCanvasFrameReceiverImpl>(),
+ std::move(request));
}
-OffscreenCanvasFrameReceiverImpl::OffscreenCanvasFrameReceiverImpl(
- mojo::InterfaceRequest<blink::mojom::OffscreenCanvasFrameReceiver> request)
- : binding_(this, std::move(request)) {}
-
-OffscreenCanvasFrameReceiverImpl::~OffscreenCanvasFrameReceiverImpl() {}
-
void OffscreenCanvasFrameReceiverImpl::SubmitCompositorFrame(
const cc::SurfaceId& surface_id,
cc::CompositorFrame frame) {

Powered by Google App Engine
This is Rietveld 408576698