Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Unified Diff: content/browser/battery_status/battery_monitor_integration_browsertest.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/battery_status/battery_monitor_integration_browsertest.cc
diff --git a/content/browser/battery_status/battery_monitor_integration_browsertest.cc b/content/browser/battery_status/battery_monitor_integration_browsertest.cc
index 9a8a23485006b754b7461ddcb1ae1576a84a15cb..b2e9e108ae8940785fd46722e1fe68f1efb51644 100644
--- a/content/browser/battery_status/battery_monitor_integration_browsertest.cc
+++ b/content/browser/battery_status/battery_monitor_integration_browsertest.cc
@@ -49,15 +49,15 @@ void UpdateBattery(const device::BatteryStatus& battery_status) {
class FakeBatteryMonitor : public device::BatteryMonitor {
public:
+ FakeBatteryMonitor() {}
+ ~FakeBatteryMonitor() override {}
+
static void Create(mojo::InterfaceRequest<BatteryMonitor> request) {
- new FakeBatteryMonitor(std::move(request));
+ mojo::MakeStrongBinding(base::MakeUnique<FakeBatteryMonitor>(),
+ std::move(request));
}
private:
- FakeBatteryMonitor(mojo::InterfaceRequest<BatteryMonitor> request)
- : binding_(this, std::move(request)) {}
- ~FakeBatteryMonitor() override {}
-
void QueryNextStatus(const QueryNextStatusCallback& callback) override {
// We don't expect overlapped calls to QueryNextStatus.
DCHECK(callback_.is_null());
@@ -81,7 +81,6 @@ class FakeBatteryMonitor : public device::BatteryMonitor {
}
std::unique_ptr<BatteryUpdateSubscription> subscription_;
- mojo::StrongBinding<BatteryMonitor> binding_;
QueryNextStatusCallback callback_;
};

Powered by Google App Engine
This is Rietveld 408576698