Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(707)

Unified Diff: components/startup_metric_utils/browser/startup_metric_host_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/startup_metric_utils/browser/startup_metric_host_impl.cc
diff --git a/components/startup_metric_utils/browser/startup_metric_host_impl.cc b/components/startup_metric_utils/browser/startup_metric_host_impl.cc
index ad4d6fd9f02fc987958ec3a91c4ad0561e67451a..d64d62602bc592208cbe3107392a0f6c0488fbdc 100644
--- a/components/startup_metric_utils/browser/startup_metric_host_impl.cc
+++ b/components/startup_metric_utils/browser/startup_metric_host_impl.cc
@@ -5,19 +5,20 @@
#include "components/startup_metric_utils/browser/startup_metric_host_impl.h"
#include "components/startup_metric_utils/browser/startup_metric_utils.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
namespace startup_metric_utils {
-// static
-void StartupMetricHostImpl::Create(mojom::StartupMetricHostRequest request) {
- new StartupMetricHostImpl(std::move(request));
-}
-StartupMetricHostImpl::StartupMetricHostImpl(
- mojom::StartupMetricHostRequest request)
- : binding_(this, std::move(request)) {}
+StartupMetricHostImpl::StartupMetricHostImpl() = default;
StartupMetricHostImpl::~StartupMetricHostImpl() = default;
+// static
+void StartupMetricHostImpl::Create(mojom::StartupMetricHostRequest request) {
+ mojo::MakeStrongBinding(base::MakeUnique<StartupMetricHostImpl>(),
+ std::move(request));
+}
+
void StartupMetricHostImpl::RecordRendererMainEntryTime(
base::TimeTicks renderer_main_entry_time) {
startup_metric_utils::RecordRendererMainEntryTime(renderer_main_entry_time);

Powered by Google App Engine
This is Rietveld 408576698