Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1370)

Unified Diff: components/safe_json/utility/safe_json_parser_mojo_impl.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/safe_json/utility/safe_json_parser_mojo_impl.cc
diff --git a/components/safe_json/utility/safe_json_parser_mojo_impl.cc b/components/safe_json/utility/safe_json_parser_mojo_impl.cc
index 45820757ce858de460bc9a2083d1209de63c65be..f3d11aae88e93242cd76a8eb7ab97f74e3df41e7 100644
--- a/components/safe_json/utility/safe_json_parser_mojo_impl.cc
+++ b/components/safe_json/utility/safe_json_parser_mojo_impl.cc
@@ -9,20 +9,19 @@
#include "base/json/json_reader.h"
#include "base/values.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
namespace safe_json {
+SafeJsonParserMojoImpl::SafeJsonParserMojoImpl() = default;
+
+SafeJsonParserMojoImpl::~SafeJsonParserMojoImpl() = default;
+
// static
void SafeJsonParserMojoImpl::Create(
mojo::InterfaceRequest<mojom::SafeJsonParser> request) {
- new SafeJsonParserMojoImpl(std::move(request));
-}
-
-SafeJsonParserMojoImpl::SafeJsonParserMojoImpl(
- mojo::InterfaceRequest<mojom::SafeJsonParser> request)
- : binding_(this, std::move(request)) {}
-
-SafeJsonParserMojoImpl::~SafeJsonParserMojoImpl() {
+ mojo::MakeStrongBinding(base::MakeUnique<SafeJsonParserMojoImpl>(),
+ std::move(request));
}
void SafeJsonParserMojoImpl::Parse(const mojo::String& json,

Powered by Google App Engine
This is Rietveld 408576698