Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11623)

Unified Diff: components/filesystem/file_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/filesystem/directory_impl.cc ('k') | components/filesystem/file_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/filesystem/file_impl.h
diff --git a/components/filesystem/file_impl.h b/components/filesystem/file_impl.h
index f7eb1b4e5c2c35e9be9bcad1045330edb5beb8cb..8ad9193777bbb4ba4d72f1dd5dfb2b2a12aaa2ec 100644
--- a/components/filesystem/file_impl.h
+++ b/components/filesystem/file_impl.h
@@ -12,7 +12,6 @@
#include "base/macros.h"
#include "components/filesystem/public/interfaces/directory.mojom.h"
#include "mojo/public/cpp/bindings/interface_request.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace base {
class FilePath;
@@ -25,13 +24,11 @@ class SharedTempDir;
class FileImpl : public mojom::File {
public:
- FileImpl(mojo::InterfaceRequest<mojom::File> request,
- const base::FilePath& path,
+ FileImpl(const base::FilePath& path,
uint32_t flags,
scoped_refptr<SharedTempDir> temp_dir,
scoped_refptr<LockTable> lock_table);
- FileImpl(mojo::InterfaceRequest<mojom::File> request,
- const base::FilePath& path,
+ FileImpl(const base::FilePath& path,
base::File file,
scoped_refptr<SharedTempDir> temp_dir,
scoped_refptr<LockTable> lock_table);
@@ -66,15 +63,13 @@ class FileImpl : public mojom::File {
void Touch(mojom::TimespecOrNowPtr atime,
mojom::TimespecOrNowPtr mtime,
const TouchCallback& callback) override;
- void Dup(mojo::InterfaceRequest<mojom::File> file,
- const DupCallback& callback) override;
+ void Dup(mojom::FileRequest file, const DupCallback& callback) override;
void Flush(const FlushCallback& callback) override;
void Lock(const LockCallback& callback) override;
void Unlock(const UnlockCallback& callback) override;
void AsHandle(const AsHandleCallback& callback) override;
private:
- mojo::StrongBinding<mojom::File> binding_;
base::File file_;
base::FilePath path_;
scoped_refptr<SharedTempDir> temp_dir_;
« no previous file with comments | « components/filesystem/directory_impl.cc ('k') | components/filesystem/file_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698