Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(401)

Unified Diff: components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h
diff --git a/components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h b/components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h
index 3cfc393c98f469d8c6d1d57be14bff082d70821c..0f6b79beae82cb79f0516349c43137f3a30b011d 100644
--- a/components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h
+++ b/components/dom_distiller/content/renderer/distiller_page_notifier_service_impl.h
@@ -8,7 +8,6 @@
#include "components/dom_distiller/content/common/distiller_page_notifier_service.mojom.h"
#include "components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h"
#include "components/dom_distiller/content/renderer/distiller_native_javascript.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace dom_distiller {
@@ -23,15 +22,13 @@ class DistillerPageNotifierServiceImpl
: public mojom::DistillerPageNotifierService {
public:
explicit DistillerPageNotifierServiceImpl(
- DistillerJsRenderFrameObserver* observer,
- mojo::InterfaceRequest<mojom::DistillerPageNotifierService> request);
+ DistillerJsRenderFrameObserver* observer);
~DistillerPageNotifierServiceImpl() override;
// Implementation of mojo interface DistillerPageNotifierService.
void NotifyIsDistillerPage() override;
private:
- mojo::StrongBinding<mojom::DistillerPageNotifierService> binding_;
DistillerJsRenderFrameObserver* distiller_js_observer_;
};

Powered by Google App Engine
This is Rietveld 408576698