components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h - Issue 2326913003: Privatize StrongBinding lifetime management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)

Patch Set: rebase Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/dom_distiller/content/browser/distiller_javascript_service_impl.cc ('k') | components/dom_distiller/content/renderer/distiller_js_render_frame_observer.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

diff --git a/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h b/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

index e21cb19ca9665085ee3993a6048ff8ea30d0ba62..a44d358d1a90697764dab481fe6c5add85520c58 100644

--- a/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

+++ b/components/dom_distiller/content/renderer/distiller_js_render_frame_observer.h

@@ -51,8 +51,6 @@ class DistillerJsRenderFrameObserver : public content::RenderFrameObserver {

// Track if the current page is distilled. This is needed for testing.

bool is_distiller_page_;

- // mojo::StrongBinding<mojom::DistillerPageNotifierService> binding_;

// Handle to "distiller" JavaScript object functionality.

std::unique_ptr<DistillerNativeJavaScript> native_javascript_handle_;

base::WeakPtrFactory<DistillerJsRenderFrameObserver> weak_factory_;