Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Unified Diff: components/dom_distiller/content/browser/distiller_javascript_service_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/dom_distiller/content/browser/distiller_javascript_service_impl.h
diff --git a/components/dom_distiller/content/browser/distiller_javascript_service_impl.h b/components/dom_distiller/content/browser/distiller_javascript_service_impl.h
index cc1659c8e9b2c6cfa8f6dccd6c185a3bb087cdf4..42f89a430a461fcd437af47ac1d224241f22578a 100644
--- a/components/dom_distiller/content/browser/distiller_javascript_service_impl.h
+++ b/components/dom_distiller/content/browser/distiller_javascript_service_impl.h
@@ -5,6 +5,7 @@
#ifndef COMPONENTS_DOM_DISTILLER_CONTENT_BROWSER_DISTILLER_JAVASCRIPT_SERVICE_IMPL_H_
#define COMPONENTS_DOM_DISTILLER_CONTENT_BROWSER_DISTILLER_JAVASCRIPT_SERVICE_IMPL_H_
+#include "base/macros.h"
#include "components/dom_distiller/content/browser/distiller_ui_handle.h"
#include "components/dom_distiller/content/common/distiller_javascript_service.mojom.h"
#include "mojo/public/cpp/bindings/string.h"
@@ -16,10 +17,8 @@ namespace dom_distiller {
class DistillerJavaScriptServiceImpl
: public mojom::DistillerJavaScriptService {
public:
- DistillerJavaScriptServiceImpl(
- content::RenderFrameHost* render_frame_host,
- DistillerUIHandle* distiller_ui_handle,
- mojo::InterfaceRequest<mojom::DistillerJavaScriptService> request);
+ DistillerJavaScriptServiceImpl(content::RenderFrameHost* render_frame_host,
+ DistillerUIHandle* distiller_ui_handle);
~DistillerJavaScriptServiceImpl() override;
// Mojo mojom::DistillerJavaScriptService implementation.
@@ -38,9 +37,10 @@ class DistillerJavaScriptServiceImpl
void HandleDistillerOpenSettingsCall() override;
private:
- mojo::StrongBinding<mojom::DistillerJavaScriptService> binding_;
content::RenderFrameHost* render_frame_host_;
DistillerUIHandle* distiller_ui_handle_;
+
+ DISALLOW_COPY_AND_ASSIGN(DistillerJavaScriptServiceImpl);
};
// static

Powered by Google App Engine
This is Rietveld 408576698