Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: components/contextual_search/browser/contextual_search_js_api_service_impl.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/contextual_search/browser/contextual_search_js_api_service_impl.h
diff --git a/components/contextual_search/browser/contextual_search_js_api_service_impl.h b/components/contextual_search/browser/contextual_search_js_api_service_impl.h
index 218e938423feb13e427cdae5e8684246e56afdb6..0b5c8b19c47384c67c98dc7a0281b96da0e1cb38 100644
--- a/components/contextual_search/browser/contextual_search_js_api_service_impl.h
+++ b/components/contextual_search/browser/contextual_search_js_api_service_impl.h
@@ -9,7 +9,6 @@
#include "components/contextual_search/browser/contextual_search_js_api_handler.h"
#include "components/contextual_search/common/contextual_search_js_api_service.mojom.h"
#include "mojo/public/cpp/bindings/string.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace contextual_search {
@@ -17,17 +16,14 @@ namespace contextual_search {
class ContextualSearchJsApiServiceImpl
: public mojom::ContextualSearchJsApiService {
public:
- ContextualSearchJsApiServiceImpl(
- ContextualSearchJsApiHandler* contextual_search_js_api_handler,
- mojo::InterfaceRequest<mojom::ContextualSearchJsApiService> request);
+ explicit ContextualSearchJsApiServiceImpl(
+ ContextualSearchJsApiHandler* contextual_search_js_api_handler);
~ContextualSearchJsApiServiceImpl() override;
// Mojo ContextualSearchApiService implementation.
void HandleSetCaption(const mojo::String& message, bool does_answer) override;
private:
- mojo::StrongBinding<mojom::ContextualSearchJsApiService> binding_;
-
// The UI handler for calls through the JavaScript API.
ContextualSearchJsApiHandler* contextual_search_js_api_handler_;

Powered by Google App Engine
This is Rietveld 408576698