Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8174)

Unified Diff: chrome/renderer/chrome_render_thread_observer.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/gpu/gpu_arc_video_service.cc ('k') | chrome/utility/chrome_content_utility_client.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/renderer/chrome_render_thread_observer.cc
diff --git a/chrome/renderer/chrome_render_thread_observer.cc b/chrome/renderer/chrome_render_thread_observer.cc
index a5752171bff3f0ca5965870051992a74d2bb3c27..486f01948734fb1041a0987c425809ccf6a110d8 100644
--- a/chrome/renderer/chrome_render_thread_observer.cc
+++ b/chrome/renderer/chrome_render_thread_observer.cc
@@ -127,13 +127,9 @@ static const int kWaitForWorkersStatsTimeoutMS = 20;
class ResourceUsageReporterImpl : public mojom::ResourceUsageReporter {
public:
- ResourceUsageReporterImpl(
- base::WeakPtr<ChromeRenderThreadObserver> observer,
- mojo::InterfaceRequest<mojom::ResourceUsageReporter> req)
- : workers_to_go_(0),
- binding_(this, std::move(req)),
- observer_(observer),
- weak_factory_(this) {}
+ explicit ResourceUsageReporterImpl(
+ base::WeakPtr<ChromeRenderThreadObserver> observer)
+ : workers_to_go_(0), observer_(observer), weak_factory_(this) {}
~ResourceUsageReporterImpl() override {}
private:
@@ -216,7 +212,6 @@ class ResourceUsageReporterImpl : public mojom::ResourceUsageReporter {
mojom::ResourceUsageDataPtr usage_data_;
GetUsageDataCallback callback_;
int workers_to_go_;
- mojo::StrongBinding<mojom::ResourceUsageReporter> binding_;
base::WeakPtr<ChromeRenderThreadObserver> observer_;
base::WeakPtrFactory<ResourceUsageReporterImpl> weak_factory_;
@@ -227,7 +222,8 @@ class ResourceUsageReporterImpl : public mojom::ResourceUsageReporter {
void CreateResourceUsageReporter(
base::WeakPtr<ChromeRenderThreadObserver> observer,
mojo::InterfaceRequest<mojom::ResourceUsageReporter> request) {
- new ResourceUsageReporterImpl(observer, std::move(request));
+ mojo::MakeStrongBinding(base::MakeUnique<ResourceUsageReporterImpl>(observer),
+ std::move(request));
}
} // namespace
« no previous file with comments | « chrome/gpu/gpu_arc_video_service.cc ('k') | chrome/utility/chrome_content_utility_client.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698