Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Unified Diff: chrome/gpu/gpu_arc_video_service.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/gpu/chrome_content_gpu_client.cc ('k') | chrome/gpu/gpu_arc_video_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/gpu/gpu_arc_video_service.h
diff --git a/chrome/gpu/gpu_arc_video_service.h b/chrome/gpu/gpu_arc_video_service.h
index 5f7275f9369744bc868b866d8a32a3d3cfdcb058..79f76f2d33d69f5f125cfc7d78ff8be151c5214c 100644
--- a/chrome/gpu/gpu_arc_video_service.h
+++ b/chrome/gpu/gpu_arc_video_service.h
@@ -12,7 +12,6 @@
#include "chrome/gpu/arc_video_accelerator.h"
#include "components/arc/common/video_accelerator.mojom.h"
#include "gpu/command_buffer/service/gpu_preferences.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace chromeos {
namespace arc {
@@ -25,15 +24,14 @@ namespace arc {
class GpuArcVideoService : public ::arc::mojom::VideoAcceleratorService,
public ArcVideoAccelerator::Client {
public:
- GpuArcVideoService(
- ::arc::mojom::VideoAcceleratorServiceRequest request,
- const gpu::GpuPreferences& gpu_preferences);
explicit GpuArcVideoService(const gpu::GpuPreferences& gpu_preferences);
~GpuArcVideoService() override;
// Connects to VideoAcceleratorServiceClient.
// |request| specified the message pipe of client to use.
- void Connect(::arc::mojom::VideoAcceleratorServiceClientRequest request);
+ static void DeprecatedConnect(
+ std::unique_ptr<GpuArcVideoService> service,
+ ::arc::mojom::VideoAcceleratorServiceClientRequest client_request);
private:
// ArcVideoAccelerator::Client implementation.
@@ -81,10 +79,6 @@ class GpuArcVideoService : public ::arc::mojom::VideoAcceleratorService,
std::unique_ptr<ArcVideoAccelerator> accelerator_;
::arc::mojom::VideoAcceleratorServiceClientPtr client_;
- // Binding of arc::mojom::VideoAcceleratorService. It also takes ownership of
- // |this|.
- mojo::StrongBinding<::arc::mojom::VideoAcceleratorService> binding_;
-
DISALLOW_COPY_AND_ASSIGN(GpuArcVideoService);
};
« no previous file with comments | « chrome/gpu/chrome_content_gpu_client.cc ('k') | chrome/gpu/gpu_arc_video_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698