Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Unified Diff: chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
diff --git a/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h b/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
index f9e267cbabc71b238212476caa118fc9965349a3..ebb49110c18f5083cf7b9fcb0681bc8009f33df8 100644
--- a/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
+++ b/chrome/browser/metrics/leak_detector/leak_detector_remote_controller.h
@@ -12,7 +12,6 @@
#include "components/metrics/leak_detector/leak_detector.mojom.h"
#include "components/metrics/proto/memory_leak_report.pb.h"
#include "mojo/public/cpp/bindings/interface_request.h"
-#include "mojo/public/cpp/bindings/strong_binding.h"
namespace metrics {
@@ -56,14 +55,12 @@ class LeakDetectorRemoteController : public mojom::LeakDetector {
static void SetLocalControllerInstance(LocalController* controller);
private:
- explicit LeakDetectorRemoteController(mojom::LeakDetectorRequest request);
+ LeakDetectorRemoteController();
// Gets called when the remote process terminates and the Mojo connection gets
// closed as a result.
void OnRemoteProcessShutdown();
- mojo::StrongBinding<mojom::LeakDetector> binding_;
-
// Indicates whether remote process received MemoryLeakReportProto::Params
// with a non-zero sampling rate, i.e. enabled leak detector.
bool leak_detector_enabled_on_remote_process_;

Powered by Google App Engine
This is Rietveld 408576698