Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: services/ui/service.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "services/ui/service.h" 5 #include "services/ui/service.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/command_line.h" 10 #include "base/command_line.h"
11 #include "base/memory/ptr_util.h" 11 #include "base/memory/ptr_util.h"
12 #include "base/memory/weak_ptr.h" 12 #include "base/memory/weak_ptr.h"
13 #include "base/threading/platform_thread.h" 13 #include "base/threading/platform_thread.h"
14 #include "base/trace_event/trace_event.h" 14 #include "base/trace_event/trace_event.h"
15 #include "build/build_config.h" 15 #include "build/build_config.h"
16 #include "mojo/public/cpp/bindings/strong_binding.h"
16 #include "services/catalog/public/cpp/resource_loader.h" 17 #include "services/catalog/public/cpp/resource_loader.h"
17 #include "services/shell/public/c/main.h" 18 #include "services/shell/public/c/main.h"
18 #include "services/shell/public/cpp/connection.h" 19 #include "services/shell/public/cpp/connection.h"
19 #include "services/shell/public/cpp/connector.h" 20 #include "services/shell/public/cpp/connector.h"
20 #include "services/tracing/public/cpp/provider.h" 21 #include "services/tracing/public/cpp/provider.h"
21 #include "services/ui/clipboard/clipboard_impl.h" 22 #include "services/ui/clipboard/clipboard_impl.h"
22 #include "services/ui/common/switches.h" 23 #include "services/ui/common/switches.h"
23 #include "services/ui/display/platform_screen.h" 24 #include "services/ui/display/platform_screen.h"
24 #include "services/ui/ime/ime_registrar_impl.h" 25 #include "services/ui/ime/ime_registrar_impl.h"
25 #include "services/ui/ime/ime_server_impl.h" 26 #include "services/ui/ime/ime_server_impl.h"
(...skipping 300 matching lines...) Expand 10 before | Expand all | Expand 10 after
326 AddUserIfNecessary(remote_identity); 327 AddUserIfNecessary(remote_identity);
327 if (!window_server_->display_manager()->has_displays()) { 328 if (!window_server_->display_manager()->has_displays()) {
328 std::unique_ptr<PendingRequest> pending_request(new PendingRequest); 329 std::unique_ptr<PendingRequest> pending_request(new PendingRequest);
329 pending_request->remote_identity = remote_identity; 330 pending_request->remote_identity = remote_identity;
330 pending_request->wtf_request.reset( 331 pending_request->wtf_request.reset(
331 new mojom::WindowTreeFactoryRequest(std::move(request))); 332 new mojom::WindowTreeFactoryRequest(std::move(request)));
332 pending_requests_.push_back(std::move(pending_request)); 333 pending_requests_.push_back(std::move(pending_request));
333 return; 334 return;
334 } 335 }
335 AddUserIfNecessary(remote_identity); 336 AddUserIfNecessary(remote_identity);
336 new ws::WindowTreeFactory(window_server_.get(), remote_identity.user_id(), 337 mojo::MakeStrongBinding(base::MakeUnique<ws::WindowTreeFactory>(
337 remote_identity.name(), std::move(request)); 338 window_server_.get(), remote_identity.user_id(),
339 remote_identity.name()),
340 std::move(request));
338 } 341 }
339 342
340 void Service::Create(const shell::Identity& remote_identity, 343 void Service::Create(const shell::Identity& remote_identity,
341 mojom::WindowTreeHostFactoryRequest request) { 344 mojom::WindowTreeHostFactoryRequest request) {
342 UserState* user_state = GetUserState(remote_identity); 345 UserState* user_state = GetUserState(remote_identity);
343 if (!user_state->window_tree_host_factory) { 346 if (!user_state->window_tree_host_factory) {
344 user_state->window_tree_host_factory.reset(new ws::WindowTreeHostFactory( 347 user_state->window_tree_host_factory.reset(new ws::WindowTreeHostFactory(
345 window_server_.get(), remote_identity.user_id())); 348 window_server_.get(), remote_identity.user_id()));
346 } 349 }
347 user_state->window_tree_host_factory->AddBinding(std::move(request)); 350 user_state->window_tree_host_factory->AddBinding(std::move(request));
348 } 351 }
349 352
350 void Service::Create(const shell::Identity& remote_identity, 353 void Service::Create(const shell::Identity& remote_identity,
351 mojom::WindowServerTestRequest request) { 354 mojom::WindowServerTestRequest request) {
352 if (!test_config_) 355 if (!test_config_)
353 return; 356 return;
354 new ws::WindowServerTestImpl(window_server_.get(), std::move(request)); 357 mojo::MakeStrongBinding(
358 base::MakeUnique<ws::WindowServerTestImpl>(window_server_.get()),
359 std::move(request));
355 } 360 }
356 361
357 362
358 } // namespace ui 363 } // namespace ui
OLDNEW
« no previous file with comments | « services/ui/ime/test_ime_driver/test_ime_driver.cc ('k') | services/ui/ws/window_server_test_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698