Privatize StrongBinding lifetime management

services/navigation/view_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "services/navigation/view_impl.h"
 
 #include "base/memory/ptr_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/interstitial_page.h"
@@ skipping 43 matching lines @@
   entry_ptr->title = base::UTF16ToUTF8(entry.GetTitle());
   entry_ptr->redirect_chain = entry.GetRedirectChain();
   return entry_ptr;
 }
 
 }  // namespace
 
 ViewImpl::ViewImpl(std::unique_ptr<shell::Connector> connector,
                    const std::string& client_user_id,
                    mojom::ViewClientPtr client,
-                   mojom::ViewRequest request,
                    std::unique_ptr<shell::ServiceContextRef> ref)
     : connector_(std::move(connector)),
-      binding_(this, std::move(request)),
       client_(std::move(client)),
       ref_(std::move(ref)),
       web_view_(new views::WebView(
           content::BrowserContext::GetBrowserContextForShellUserId(
               client_user_id))) {
   web_view_->GetWebContents()->SetDelegate(this);
   const content::NavigationController* controller =
       &web_view_->GetWebContents()->GetController();
   registrar_.Add(this, content::NOTIFICATION_NAV_ENTRY_PENDING,
                  content::Source<content::NavigationController>(controller));
@@ skipping 67 matching lines @@
   mojom::ViewClientPtr client;
   mojom::ViewPtr view;
   mojom::ViewRequest view_request = GetProxy(&view);
   client_->ViewCreated(std::move(view), GetProxy(&client),
                        disposition == WindowOpenDisposition::NEW_POPUP,
                        initial_rect, user_gesture);
 
   const std::string new_user_id =
       content::BrowserContext::GetShellUserIdFor(
           new_contents->GetBrowserContext());
-  ViewImpl* impl = new ViewImpl(
-      connector_->Clone(), new_user_id, std::move(client),
-      std::move(view_request), ref_->Clone());
+  auto impl = base::MakeUnique<ViewImpl>(connector_->Clone(), new_user_id,
+                                         std::move(client), ref_->Clone());
+
   // TODO(beng): This is a bit crappy. should be able to create the ViewImpl
   //             with |new_contents| instead.
   impl->web_view_->SetWebContents(new_contents);
-  impl->web_view_->GetWebContents()->SetDelegate(impl);
+  impl->web_view_->GetWebContents()->SetDelegate(impl.get());
 
   // TODO(beng): this reply is currently synchronous, figure out a fix.
   if (was_blocked)
     *was_blocked = false;
+
+  mojo::MakeStrongBinding(std::move(impl), std::move(view_request));
 }
 
 void ViewImpl::CloseContents(content::WebContents* source) {
   client_->Close();
 }
 
 content::WebContents* ViewImpl::OpenURLFromTab(
     content::WebContents* source,
     const content::OpenURLParams& params) {
   mojom::OpenURLParamsPtr params_ptr = mojom::OpenURLParams::New();
@@ skipping 123 matching lines @@
 
 views::Widget* ViewImpl::GetWidget() {
   return web_view_->GetWidget();
 }
 
 const views::Widget* ViewImpl::GetWidget() const {
   return web_view_->GetWidget();
 }
 
 }  // navigation