Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(665)

Side by Side Diff: device/serial/serial_connection.cc

Issue 2326913003: Privatize StrongBinding lifetime management (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « device/serial/serial_connection.h ('k') | device/serial/serial_connection_factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "device/serial/serial_connection.h" 5 #include "device/serial/serial_connection.h"
6 6
7 #include <utility> 7 #include <utility>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "device/serial/buffer.h" 10 #include "device/serial/buffer.h"
11 #include "device/serial/data_sink_receiver.h" 11 #include "device/serial/data_sink_receiver.h"
12 #include "device/serial/data_source_sender.h" 12 #include "device/serial/data_source_sender.h"
13 #include "device/serial/serial_io_handler.h" 13 #include "device/serial/serial_io_handler.h"
14 14
15 namespace device { 15 namespace device {
16 16
17 SerialConnection::SerialConnection( 17 SerialConnection::SerialConnection(
18 scoped_refptr<SerialIoHandler> io_handler, 18 scoped_refptr<SerialIoHandler> io_handler,
19 mojo::InterfaceRequest<serial::DataSink> sink, 19 mojo::InterfaceRequest<serial::DataSink> sink,
20 mojo::InterfaceRequest<serial::DataSource> source, 20 mojo::InterfaceRequest<serial::DataSource> source,
21 mojo::InterfacePtr<serial::DataSourceClient> source_client, 21 mojo::InterfacePtr<serial::DataSourceClient> source_client)
22 mojo::InterfaceRequest<serial::Connection> request) 22 : io_handler_(io_handler) {
23 : io_handler_(io_handler), binding_(this, std::move(request)) {
24 receiver_ = new DataSinkReceiver( 23 receiver_ = new DataSinkReceiver(
25 std::move(sink), 24 std::move(sink),
26 base::Bind(&SerialConnection::OnSendPipeReady, base::Unretained(this)), 25 base::Bind(&SerialConnection::OnSendPipeReady, base::Unretained(this)),
27 base::Bind(&SerialConnection::OnSendCancelled, base::Unretained(this)), 26 base::Bind(&SerialConnection::OnSendCancelled, base::Unretained(this)),
28 base::Bind(base::DoNothing)); 27 base::Bind(base::DoNothing));
29 sender_ = new DataSourceSender( 28 sender_ = new DataSourceSender(
30 std::move(source), std::move(source_client), 29 std::move(source), std::move(source_client),
31 base::Bind(&SerialConnection::OnReceivePipeReady, base::Unretained(this)), 30 base::Bind(&SerialConnection::OnReceivePipeReady, base::Unretained(this)),
32 base::Bind(base::DoNothing)); 31 base::Bind(base::DoNothing));
33 } 32 }
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
71 void SerialConnection::OnSendPipeReady(std::unique_ptr<ReadOnlyBuffer> buffer) { 70 void SerialConnection::OnSendPipeReady(std::unique_ptr<ReadOnlyBuffer> buffer) {
72 io_handler_->Write(std::move(buffer)); 71 io_handler_->Write(std::move(buffer));
73 } 72 }
74 73
75 void SerialConnection::OnReceivePipeReady( 74 void SerialConnection::OnReceivePipeReady(
76 std::unique_ptr<WritableBuffer> buffer) { 75 std::unique_ptr<WritableBuffer> buffer) {
77 io_handler_->Read(std::move(buffer)); 76 io_handler_->Read(std::move(buffer));
78 } 77 }
79 78
80 } // namespace device 79 } // namespace device
OLDNEW
« no previous file with comments | « device/serial/serial_connection.h ('k') | device/serial/serial_connection_factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698