Privatize StrongBinding lifetime management

components/filesystem/file_impl.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/filesystem/file_impl.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <limits>
 #include <utility>
 
 #include "base/files/file_path.h"
 #include "base/files/scoped_file.h"
 #include "base/logging.h"
 #include "build/build_config.h"
 #include "components/filesystem/lock_table.h"
 #include "components/filesystem/shared_temp_dir.h"
 #include "components/filesystem/util.h"
 #include "mojo/common/common_type_converters.h"
+#include "mojo/public/cpp/bindings/strong_binding.h"
 #include "mojo/public/cpp/system/platform_handle.h"
 
 static_assert(sizeof(off_t) <= sizeof(int64_t), "off_t too big");
 static_assert(sizeof(size_t) >= sizeof(uint32_t), "size_t too small");
 
 using base::Time;
 using mojo::ScopedHandle;
 
 namespace filesystem {
 namespace {
 
 const size_t kMaxReadSize = 1 * 1024 * 1024;  // 1 MB.
 
 }  // namespace
 
-FileImpl::FileImpl(mojo::InterfaceRequest<mojom::File> request,
-                   const base::FilePath& path,
+FileImpl::FileImpl(const base::FilePath& path,
                    uint32_t flags,
                    scoped_refptr<SharedTempDir> temp_dir,
                    scoped_refptr<LockTable> lock_table)
-    : binding_(this, std::move(request)),
-      file_(path, flags),
+    : file_(path, flags),
       path_(path),
       temp_dir_(std::move(temp_dir)),
       lock_table_(std::move(lock_table)) {
   DCHECK(file_.IsValid());
 }
 
-FileImpl::FileImpl(mojo::InterfaceRequest<mojom::File> request,
-                   const base::FilePath& path,
+FileImpl::FileImpl(const base::FilePath& path,
                    base::File file,
                    scoped_refptr<SharedTempDir> temp_dir,
                    scoped_refptr<LockTable> lock_table)
-    : binding_(this, std::move(request)),
-      file_(std::move(file)),
+    : file_(std::move(file)),
       path_(path),
       temp_dir_(std::move(temp_dir)),
       lock_table_(std::move(lock_table)) {
   DCHECK(file_.IsValid());
 }
 
 FileImpl::~FileImpl() {
   if (file_.IsValid())
     lock_table_->RemoveFromLockTable(path_);
 }
@@ skipping 216 matching lines @@
 
     base_mtime = info.last_modified;
   } else if (!mtime->now) {
     base_mtime = Time::FromDoubleT(mtime->seconds);
   }
 
   file_.SetTimes(base_atime, base_mtime);
   callback.Run(mojom::FileError::OK);
 }
 
-void FileImpl::Dup(mojo::InterfaceRequest<mojom::File> file,
-                   const DupCallback& callback) {
+void FileImpl::Dup(mojom::FileRequest file, const DupCallback& callback) {
   if (!file_.IsValid()) {
     callback.Run(GetError(file_));
     return;
   }
 
   base::File new_file = file_.Duplicate();
   if (!new_file.IsValid()) {
     callback.Run(GetError(new_file));
     return;
   }
 
-  if (file.is_pending())
-    new FileImpl(std::move(file), path_, std::move(new_file), temp_dir_,
-                 lock_table_);
+  if (file.is_pending()) {
+    mojo::MakeStrongBinding(
+        base::MakeUnique<FileImpl>(path_, std::move(new_file), temp_dir_,
+                                   lock_table_),
+        std::move(file));
+  }
   callback.Run(mojom::FileError::OK);
 }
 
 void FileImpl::Flush(const FlushCallback& callback) {
   if (!file_.IsValid()) {
     callback.Run(GetError(file_));
     return;
   }
 
   bool ret = file_.Flush();
@@ skipping 35 matching lines @@
   if (info.is_directory) {
     callback.Run(mojom::FileError::NOT_A_FILE, ScopedHandle());
     return;
   }
 
   callback.Run(mojom::FileError::OK,
                mojo::WrapPlatformFile(new_file.TakePlatformFile()));
 }
 
 }  // namespace filesystem