Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2326893002: Change type of sample_count_sum from int to uint64_t to fix possible overflow (Closed)

Created:
4 years, 3 months ago by kqyang
Modified:
4 years, 3 months ago
Reviewers:
wolenetz, Will Harris
CC:
chromium-reviews, feature-media-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Change type of sample_count_sum from int to uint64_t to fix possible overflow BUG=644373 Committed: https://crrev.com/5a30782ddb6a7c5f4a1a073253e4a162d82864df Cr-Commit-Position: refs/heads/master@{#417490}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -6 lines) Patch
M media/formats/mp4/track_run_iterator.cc View 4 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kqyang
Please review!
4 years, 3 months ago (2016-09-08 23:10:10 UTC) #2
Will Harris
lgtm
4 years, 3 months ago (2016-09-08 23:15:54 UTC) #3
wolenetz
lgtm
4 years, 3 months ago (2016-09-08 23:44:23 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326893002/1
4 years, 3 months ago (2016-09-08 23:44:42 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_clang on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/82985)
4 years, 3 months ago (2016-09-08 23:55:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326893002/1
4 years, 3 months ago (2016-09-09 01:38:08 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-09 03:14:17 UTC) #11
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 03:17:00 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5a30782ddb6a7c5f4a1a073253e4a162d82864df
Cr-Commit-Position: refs/heads/master@{#417490}

Powered by Google App Engine
This is Rietveld 408576698