CPWL_Color::ConvertColorType should compare current color type with the given convert color type.

CPWL_Color::ConvertColorType should compare current color type with the given convert color type.

Previously, it compred the given convert color type with itself. So
CPWL_Color::ConvertColorType never converted the color into the given
type.

Committed: https://pdfium.googlesource.com/pdfium/+/cba85abc8a9d2c458b423f0cc3b79a24ddd3f58e

[jaepark, 2016-09-08 23:06:39]

The CQ bit was checked by jaepark@google.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 23:06:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 23:19:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 23:19:14]

Dry run: This issue passed the CQ dry run.

[jaepark, 2016-09-08 23:20:09]

jaepark@google.com changed reviewers:
+ dsinclair@chromium.org, thestig@chromium.org

[dsinclair, 2016-09-09 00:09:26]

https://codereview.chromium.org/2326883002/diff/1/fpdfsdk/pdfwindow/PWL_Utils...
File fpdfsdk/pdfwindow/PWL_Utils.cpp (right):

https://codereview.chromium.org/2326883002/diff/1/fpdfsdk/pdfwindow/PWL_Utils...
fpdfsdk/pdfwindow/PWL_Utils.cpp:3315: switch (nColorType) {
Are we sure nColorType is the correct item for the outer switch? It's hard to
tell from reading the code if the colour we're going too should be here, or the
colour we're going from.

[jaepark, 2016-09-09 00:39:41]

https://codereview.chromium.org/2326883002/diff/1/fpdfsdk/pdfwindow/PWL_Utils...
File fpdfsdk/pdfwindow/PWL_Utils.cpp (right):

https://codereview.chromium.org/2326883002/diff/1/fpdfsdk/pdfwindow/PWL_Utils...
fpdfsdk/pdfwindow/PWL_Utils.cpp:3315: switch (nColorType) {
On 2016/09/09 00:09:26, dsinclair wrote:
> Are we sure nColorType is the correct item for the outer switch? It's hard to
> tell from reading the code if the colour we're going too should be here, or
the
> colour we're going from.

Since the inner switch is calling functions OUTER2INNER, I think the color we're
going from is in the outer switch.

[dsinclair, 2016-09-09 01:09:32]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-09-09 01:09:33]

lgtm

[commit-bot: I haz the power, 2016-09-09 01:09:44]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 01:10:07]

Description was changed from

==========
CPWL_Color::ConvertColorType should compare current color type with the given
convert color type.

Previously, it compred the given convert color type with itself. So
CPWL_Color::ConvertColorType never converted the color into the given
type.
==========

to

==========
CPWL_Color::ConvertColorType should compare current color type with the given
convert color type.

Previously, it compred the given convert color type with itself. So
CPWL_Color::ConvertColorType never converted the color into the given
type.

Committed:
https://pdfium.googlesource.com/pdfium/+/cba85abc8a9d2c458b423f0cc3b79a24ddd3...
==========

[commit-bot: I haz the power, 2016-09-09 01:10:09]

Committed patchset #1 (id:1) as
https://pdfium.googlesource.com/pdfium/+/cba85abc8a9d2c458b423f0cc3b79a24ddd3...