Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 232683003: Fix for often broken fling scrolls on Aura (Closed)

Created:
6 years, 8 months ago by bokan
Modified:
6 years, 8 months ago
Reviewers:
jdduke (slow)
CC:
chromium-reviews, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Fix for often broken fling scrolls on Aura Because the Animate() method was recently changed to pass the current frame's tick time in r259735, getting the diff between it and the fling's start time would often result in a negative time delta. This caused the fling to report no scrolling and the scroll would stop. We still want to start flinging immediately where possible so instead of letting Animate() always set the startTime and losing a frame, we do it only for a non-positive time delta. This does not affect Android since its gesture fling ignores the passed delta and uses gfx::FrameTime::Now(). BUG=360633 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=263104

Patch Set 1 #

Patch Set 2 : Added test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
M content/renderer/input/input_handler_proxy.cc View 1 chunk +2 lines, -1 line 0 comments Download
M content/renderer/input/input_handler_proxy_unittest.cc View 1 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
bokan
6 years, 8 months ago (2014-04-10 16:50:01 UTC) #1
jdduke (slow)
lgtm
6 years, 8 months ago (2014-04-10 16:58:47 UTC) #2
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 8 months ago (2014-04-10 16:59:54 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/232683003/10001
6 years, 8 months ago (2014-04-10 17:00:12 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-10 17:51:06 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.chromium on linux_chromium_chromeos_rel
6 years, 8 months ago (2014-04-10 17:51:07 UTC) #6
bokan
The CQ bit was checked by bokan@chromium.org
6 years, 8 months ago (2014-04-10 17:56:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bokan@chromium.org/232683003/10001
6 years, 8 months ago (2014-04-10 17:57:28 UTC) #8
commit-bot: I haz the power
6 years, 8 months ago (2014-04-10 22:44:10 UTC) #9
Message was sent while issue was closed.
Change committed as 263104

Powered by Google App Engine
This is Rietveld 408576698