Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2326813002: Replace and remove JavaException(s). (Closed)

Created:
4 years, 3 months ago by scheglov
Modified:
4 years, 3 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -366 lines) Patch
M pkg/analysis_server/test/completion_test_support.dart View 3 chunks +5 lines, -5 lines 0 comments Download
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/context/source.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/ast.dart View 7 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/dart/ast/utilities.dart View 4 chunks +7 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/dart/constant/value.dart View 8 chunks +8 lines, -10 lines 2 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/dart/element/member.dart View 5 chunks +8 lines, -8 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/type.dart View 8 chunks +25 lines, -23 lines 0 comments Download
M pkg/analyzer/lib/src/dart/resolver/scope.dart View 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_core.dart View 6 chunks +2 lines, -57 lines 2 comments Download
M pkg/analyzer/lib/src/generated/java_engine.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/java_io.dart View 2 chunks +1 line, -6 lines 0 comments Download
M pkg/analyzer/lib/src/generated/parser.dart View 9 chunks +12 lines, -44 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 8 chunks +9 lines, -11 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/source_io.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/generated/testing/element_factory.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/utilities_collection.dart View 7 chunks +7 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/element_resolver_test.dart View 5 chunks +30 lines, -50 lines 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/resolver_test.dart View 2 chunks +6 lines, -15 lines 0 comments Download
M pkg/analyzer/test/generated/resolver_test_case.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/analyzer/test/generated/source_factory_test.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_analyzer_test.dart View 3 chunks +2 lines, -13 lines 0 comments Download
M pkg/analyzer/test/generated/test_support.dart View 5 chunks +5 lines, -6 lines 0 comments Download
M pkg/analyzer/test/generated/utilities_test.dart View 6 chunks +21 lines, -67 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
4 years, 3 months ago (2016-09-08 22:05:05 UTC) #1
Brian Wilkerson
lgtm https://codereview.chromium.org/2326813002/diff/1/pkg/analyzer/lib/src/dart/constant/value.dart File pkg/analyzer/lib/src/dart/constant/value.dart (right): https://codereview.chromium.org/2326813002/diff/1/pkg/analyzer/lib/src/dart/constant/value.dart#newcode1234 pkg/analyzer/lib/src/dart/constant/value.dart:1234: class EvaluationException { Should we do make this ...
4 years, 3 months ago (2016-09-08 22:38:57 UTC) #2
scheglov
https://codereview.chromium.org/2326813002/diff/1/pkg/analyzer/lib/src/dart/constant/value.dart File pkg/analyzer/lib/src/dart/constant/value.dart (right): https://codereview.chromium.org/2326813002/diff/1/pkg/analyzer/lib/src/dart/constant/value.dart#newcode1234 pkg/analyzer/lib/src/dart/constant/value.dart:1234: class EvaluationException { On 2016/09/08 22:38:57, Brian Wilkerson wrote: ...
4 years, 3 months ago (2016-09-08 22:48:13 UTC) #3
scheglov
4 years, 3 months ago (2016-09-08 22:56:40 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
e976e692be5fcd33a69d11269d9b0d59f14d2838 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698