Simplified compound feature extraction.

Simplified compound feature extraction.

Started to return the last simple selector in the compound instead of
the pointer to the next compound from
extractInvalidationSetFeaturesFromCompound. That means we can update
feature flags for the combinator from updateInvalidationSets, which
also means we can get rid of the duplicated code for updating the
nthInvalidationSet(). Additionally, we can use the siblingFeatures as
initialized by updateFeaturesFromCombinator().

Removed unused UseFeatureTypes.

There should be no functional changes.

R=ericwilligers@chromium.org

Committed: https://crrev.com/7496acab2a6b8a75615788f5f623018cefe1c0b1
Cr-Commit-Position: refs/heads/master@{#417915}

[rune, 2016-09-08 21:25:33]

The CQ bit was checked by rune@opera.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-08 21:26:19]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[rune, 2016-09-08 21:30:34]

ptal

[commit-bot: I haz the power, 2016-09-09 00:20:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-09 00:20:30]

Dry run: This issue passed the CQ dry run.

[Eric Willigers, 2016-09-11 23:28:37]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-09-11 23:28:38]

lgtm

[commit-bot: I haz the power, 2016-09-11 23:28:42]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Eric Willigers, 2016-09-11 23:56:01]

The CQ bit was unchecked by ericwilligers@chromium.org

[Eric Willigers, 2016-09-11 23:58:03]

lgtm

https://codereview.chromium.org/2326783002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/RuleFeature.cpp (left):

https://codereview.chromium.org/2326783002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/RuleFeature.cpp:526: for (; simpleSelector;
simpleSelector = simpleSelector->tagHistory()) {
Another option would be

  for (;; simpleSelector = simpleSelector->tagHistory()) {
    ...
    if (!simpleSelector->tagHistory() || simpleSelector->relation() !=
CSSSelector::SubSelector)
      return simpleSelector;
  }
}

[rune, 2016-09-12 08:01:58]

Added a NOTREACHED() as end-of-method should no longer be reached.

https://codereview.chromium.org/2326783002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/css/RuleFeature.cpp (left):

https://codereview.chromium.org/2326783002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/css/RuleFeature.cpp:526: for (; simpleSelector;
simpleSelector = simpleSelector->tagHistory()) {
On 2016/09/11 23:58:03, Eric Willigers wrote:
> Another option would be
> 
>   for (;; simpleSelector = simpleSelector->tagHistory()) {
>     ...
>     if (!simpleSelector->tagHistory() || simpleSelector->relation() !=
> CSSSelector::SubSelector)
>       return simpleSelector;
>   }
> }

Done.

[Eric Willigers, 2016-09-12 08:07:43]

The CQ bit was checked by ericwilligers@chromium.org

[Eric Willigers, 2016-09-12 08:07:43]

lgtm

[commit-bot: I haz the power, 2016-09-12 08:07:54]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 08:44:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-12 08:44:41]

Try jobs failed on following builders:
  win_chromium_compile_dbg_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)

[rune, 2016-09-12 09:45:54]

The CQ bit was checked by rune@opera.com

[rune, 2016-09-12 09:45:54]

The patchset sent to the CQ was uploaded after l-g-t-m from
ericwilligers@chromium.org
Link to the patchset: https://codereview.chromium.org/2326783002/#ps60001
(title: "Unreachable code detected by compiler.")

[commit-bot: I haz the power, 2016-09-12 09:46:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-12 10:57:43]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-09-12 10:59:59]

Description was changed from

==========
Simplified compound feature extraction.

Started to return the last simple selector in the compound instead of
the pointer to the next compound from
extractInvalidationSetFeaturesFromCompound. That means we can update
feature flags for the combinator from updateInvalidationSets, which
also means we can get rid of the duplicated code for updating the
nthInvalidationSet(). Additionally, we can use the siblingFeatures as
initialized by updateFeaturesFromCombinator().

Removed unused UseFeatureTypes.

There should be no functional changes.

R=ericwilligers@chromium.org
==========

to

==========
Simplified compound feature extraction.

Started to return the last simple selector in the compound instead of
the pointer to the next compound from
extractInvalidationSetFeaturesFromCompound. That means we can update
feature flags for the combinator from updateInvalidationSets, which
also means we can get rid of the duplicated code for updating the
nthInvalidationSet(). Additionally, we can use the siblingFeatures as
initialized by updateFeaturesFromCombinator().

Removed unused UseFeatureTypes.

There should be no functional changes.

R=ericwilligers@chromium.org

Committed: https://crrev.com/7496acab2a6b8a75615788f5f623018cefe1c0b1
Cr-Commit-Position: refs/heads/master@{#417915}
==========

[commit-bot: I haz the power, 2016-09-12 11:00:00]

Patchset 4 (id:??) landed as
https://crrev.com/7496acab2a6b8a75615788f5f623018cefe1c0b1
Cr-Commit-Position: refs/heads/master@{#417915}