Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(555)

Issue 2326773002: Add a use counter of css clip of fixed-pos elements. (Closed)

Created:
4 years, 3 months ago by chrishtr
Modified:
4 years, 3 months ago
Reviewers:
pdr., Mark P
CC:
asvitkine+watch_chromium.org, blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add a use counter of css clip of fixed-pos elements. BUG=644510 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/6b9233a9d980ab703c719682f3700b28a75cc5f0 Cr-Commit-Position: refs/heads/master@{#417524}

Patch Set 1 #

Patch Set 2 : none #

Total comments: 2

Patch Set 3 : none #

Patch Set 4 : none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/UseCounter.h View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 1 chunk +2 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 29 (19 generated)
chrishtr
4 years, 3 months ago (2016-09-08 21:16:39 UTC) #4
pdr.
On 2016/09/08 at 21:16:39, chrishtr wrote: > LGTM
4 years, 3 months ago (2016-09-08 21:20:09 UTC) #7
chrishtr
4 years, 3 months ago (2016-09-08 21:49:14 UTC) #16
Mark P
histograms.xml lgtm with one comment https://codereview.chromium.org/2326773002/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2326773002/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.h#newcode1288 third_party/WebKit/Source/core/frame/UseCounter.h:1288: nit: no extra blank ...
4 years, 3 months ago (2016-09-08 21:57:18 UTC) #17
chrishtr
https://codereview.chromium.org/2326773002/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.h File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2326773002/diff/20001/third_party/WebKit/Source/core/frame/UseCounter.h#newcode1288 third_party/WebKit/Source/core/frame/UseCounter.h:1288: On 2016/09/08 at 21:57:18, Mark P wrote: > nit: ...
4 years, 3 months ago (2016-09-08 22:04:23 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326773002/40001
4 years, 3 months ago (2016-09-08 22:05:11 UTC) #21
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h: While running git apply --index -3 -p1; error: patch ...
4 years, 3 months ago (2016-09-09 00:56:32 UTC) #23
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326773002/60001
4 years, 3 months ago (2016-09-09 02:36:47 UTC) #26
commit-bot: I haz the power
Committed patchset #4 (id:60001)
4 years, 3 months ago (2016-09-09 07:28:22 UTC) #27
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 07:30:19 UTC) #29
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/6b9233a9d980ab703c719682f3700b28a75cc5f0
Cr-Commit-Position: refs/heads/master@{#417524}

Powered by Google App Engine
This is Rietveld 408576698