|
|
DescriptionAdd a use counter of css clip of fixed-pos elements.
BUG=644510
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Committed: https://crrev.com/6b9233a9d980ab703c719682f3700b28a75cc5f0
Cr-Commit-Position: refs/heads/master@{#417524}
Patch Set 1 #Patch Set 2 : none #
Total comments: 2
Patch Set 3 : none #Patch Set 4 : none #
Messages
Total messages: 29 (19 generated)
Description was changed from ========== none none BUG= ========== to ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
Description was changed from ========== none none BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Add a use counter of css clip of fixed-pos elements. BUG=644510 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ==========
chrishtr@chromium.org changed reviewers: + pdr@chromium.org
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2016/09/08 at 21:16:39, chrishtr wrote: > LGTM
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org Link to the patchset: https://codereview.chromium.org/2326773002/#ps20001 (title: "none")
The CQ bit was unchecked by chrishtr@chromium.org
The CQ bit was checked by chrishtr@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
chrishtr@chromium.org changed reviewers: + mpearson@chromium.org
histograms.xml lgtm with one comment https://codereview.chromium.org/2326773002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2326773002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/frame/UseCounter.h:1288: nit: no extra blank line.
https://codereview.chromium.org/2326773002/diff/20001/third_party/WebKit/Sour... File third_party/WebKit/Source/core/frame/UseCounter.h (right): https://codereview.chromium.org/2326773002/diff/20001/third_party/WebKit/Sour... third_party/WebKit/Source/core/frame/UseCounter.h:1288: On 2016/09/08 at 21:57:18, Mark P wrote: > nit: no extra blank line. Fixed.
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org, mpearson@chromium.org Link to the patchset: https://codereview.chromium.org/2326773002/#ps40001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Failed to apply patch for third_party/WebKit/Source/core/frame/UseCounter.h: While running git apply --index -3 -p1; error: patch failed: third_party/WebKit/Source/core/frame/UseCounter.h:1285 Falling back to three-way merge... Applied patch to 'third_party/WebKit/Source/core/frame/UseCounter.h' with conflicts. U third_party/WebKit/Source/core/frame/UseCounter.h Patch: third_party/WebKit/Source/core/frame/UseCounter.h Index: third_party/WebKit/Source/core/frame/UseCounter.h diff --git a/third_party/WebKit/Source/core/frame/UseCounter.h b/third_party/WebKit/Source/core/frame/UseCounter.h index e023d8fbfe8132ff9fc3e771afa0e4232d2b4e16..d68daca3cea3e7735810c9dc313cbe7fbc516632 100644 --- a/third_party/WebKit/Source/core/frame/UseCounter.h +++ b/third_party/WebKit/Source/core/frame/UseCounter.h @@ -1285,6 +1285,7 @@ public: MetaSetCookieWhenCSPBlocksInlineScript = 1549, MetaRefreshWhenCSPBlocksInlineScript = 1550, PanScrollingStart = 1551, + ClipCssOfFixedPositionElement = 1552, // Add new features immediately above this line. Don't change assigned // numbers of any item, and don't reuse removed slots.
The CQ bit was checked by chrishtr@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from pdr@chromium.org, mpearson@chromium.org Link to the patchset: https://codereview.chromium.org/2326773002/#ps60001 (title: "none")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #4 (id:60001)
Message was sent while issue was closed.
Description was changed from ========== Add a use counter of css clip of fixed-pos elements. BUG=644510 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 ========== to ========== Add a use counter of css clip of fixed-pos elements. BUG=644510 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/6b9233a9d980ab703c719682f3700b28a75cc5f0 Cr-Commit-Position: refs/heads/master@{#417524} ==========
Message was sent while issue was closed.
Patchset 4 (id:??) landed as https://crrev.com/6b9233a9d980ab703c719682f3700b28a75cc5f0 Cr-Commit-Position: refs/heads/master@{#417524} |