Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Unified Diff: third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp

Issue 2326743003: Do not call MemoryCache::prune() when a client/observer is removed (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove justReleasedResource Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp
diff --git a/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp b/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp
index 48c639403acd5b6ade886e78ddd4a9d1e2f7b0b1..251ca9c2f201752749e7bf5a394d94f2b977c38a 100644
--- a/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp
+++ b/third_party/WebKit/Source/core/fetch/MemoryCacheTest.cpp
@@ -312,8 +312,7 @@ static void TestClientRemoval(Resource* resource1, Resource* resource2)
EXPECT_EQ(0u, memoryCache()->deadSize());
EXPECT_EQ(resource1->size() + resource2->size(), memoryCache()->liveSize());
- // Removing the client from resource1 should result in all resources
- // remaining in cache since the prune is deferred.
+ // Removing the client from resource1 should not trigger pruning.
client1->removeAsClient();
EXPECT_GT(resource1->decodedSize(), 0u);
EXPECT_GT(resource2->decodedSize(), 0u);
@@ -322,15 +321,25 @@ static void TestClientRemoval(Resource* resource1, Resource* resource2)
EXPECT_TRUE(memoryCache()->contains(resource1));
EXPECT_TRUE(memoryCache()->contains(resource2));
- // Removing the client from resource2 should result in immediate
- // eviction of resource2 because we are over the prune deferral limit.
+ // Removing the client from resource2 should not trigger pruning.
client2->removeAsClient();
EXPECT_GT(resource1->decodedSize(), 0u);
EXPECT_GT(resource2->decodedSize(), 0u);
- EXPECT_EQ(resource1->size(), memoryCache()->deadSize());
+ EXPECT_EQ(resource1->size() + resource2->size(), memoryCache()->deadSize());
EXPECT_EQ(0u, memoryCache()->liveSize());
EXPECT_TRUE(memoryCache()->contains(resource1));
- EXPECT_FALSE(memoryCache()->contains(resource2));
+ EXPECT_TRUE(memoryCache()->contains(resource2));
+
+ WeakPersistent<Resource> resource1Weak = resource1;
+ WeakPersistent<Resource> resource2Weak = resource2;
+
+ ThreadState::current()->collectGarbage(BlinkGC::NoHeapPointersOnStack, BlinkGC::GCWithSweep, BlinkGC::ForcedGC);
+ // Resources are garbage-collected (WeakMemoryCache) and thus removed
+ // from MemoryCache.
+ EXPECT_FALSE(resource1Weak);
+ EXPECT_FALSE(resource2Weak);
+ EXPECT_EQ(0u, memoryCache()->deadSize());
+ EXPECT_EQ(0u, memoryCache()->liveSize());
}
TEST_F(MemoryCacheTest, ClientRemoval_Basic)
« no previous file with comments | « third_party/WebKit/Source/core/fetch/MemoryCache.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698