Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(21)

Unified Diff: chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc

Issue 2326723003: Discount for inactivity timeout for recording session length (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc
diff --git a/chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc b/chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc
index 92e6c59601e2a4dcaed014cd8a6ef4c6081c6b84..b64ebddc13b028f712169397fd12b0f2265262eb 100644
--- a/chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc
+++ b/chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc
@@ -117,6 +117,11 @@ void DesktopEngagementService::EndSession() {
in_session_ = false;
base::TimeDelta delta = base::TimeTicks::Now() - session_start_;
+
+ // If timer is not running then session ended because of inactivity.
+ if (!timer_.IsRunning())
Alexei Svitkine (slow) 2016/09/08 21:20:14 Is there a way we can have a test for this? I'm j
gayane -on leave until 09-2017 2016/09/09 18:11:03 Done.
+ delta -= inactivity_timeout_;
+
DVLOG(4) << "Logging session length of " << delta.InSeconds() << " seconds.";
// Note: This metric is recorded separately for Android in
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698