Discount for inactivity timeout for recording session length

Discount for inactivity timeout for recording session length.

When session ends because of timeout we should subtract the
waiting time for more accurate session length.

BUG=645538
Committed: https://crrev.com/f1abb8e62246a9514974aab9d0b547d570903ef9
Cr-Commit-Position: refs/heads/master@{#417672}

[gayane -on leave until 09-2017, 2016-09-08 20:24:18]

Description was changed from

==========
format fix


Discount for inactivity timeout for recording session length

BUG=
==========

to

==========
Discount for inactivity timeout for recording session length.

When session ends because of timeout we should subtract the waiting time for
more accurate session length.
==========

[gayane -on leave until 09-2017, 2016-09-08 20:24:28]

Description was changed from

==========
Discount for inactivity timeout for recording session length.

When session ends because of timeout we should subtract the waiting time for
more accurate session length.
==========

to

==========
Discount for inactivity timeout for recording session length.

When session ends because of timeout we should subtract the
waiting time for more accurate session length.
==========

[gayane -on leave until 09-2017, 2016-09-08 20:24:51]

gayane@chromium.org changed reviewers:
+ asvitkine@chromium.org

[gayane -on leave until 09-2017, 2016-09-08 20:26:16]

Patchset #1 (id:1) has been deleted

[Alexei Svitkine (slow), 2016-09-08 21:20:14]

https://codereview.chromium.org/2326723003/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc
(right):

https://codereview.chromium.org/2326723003/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc:122: if
(!timer_.IsRunning())
Is there a way we can have a test for this?

I'm just worried about some case where this invariant could change in the
future.

Also, please update histograms.xml description of the metric noting this M55+
logic change on desktop,

[gayane -on leave until 09-2017, 2016-09-09 18:10:48]

Patchset #2 (id:40001) has been deleted

[gayane -on leave until 09-2017, 2016-09-09 18:11:03]

Thanks. Have one more look.

https://codereview.chromium.org/2326723003/diff/20001/chrome/browser/metrics/...
File chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc
(right):

https://codereview.chromium.org/2326723003/diff/20001/chrome/browser/metrics/...
chrome/browser/metrics/desktop_engagement/desktop_engagement_service.cc:122: if
(!timer_.IsRunning())
On 2016/09/08 21:20:14, Alexei Svitkine (very slow) wrote:
> Is there a way we can have a test for this?
> 
> I'm just worried about some case where this invariant could change in the
> future.
> 
> Also, please update histograms.xml description of the metric noting this M55+
> logic change on desktop,

Done.

[Alexei Svitkine (slow), 2016-09-09 18:26:23]

lgtm

Please create a crbug for this change and set it as BUG= in the description.
Thanks!

https://codereview.chromium.org/2326723003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2326723003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:54449: +    timeout.
Nit: add "on desktop." to the end of the sentence.

[gayane -on leave until 09-2017, 2016-09-09 18:30:03]

Description was changed from

==========
Discount for inactivity timeout for recording session length.

When session ends because of timeout we should subtract the
waiting time for more accurate session length.
==========

to

==========
Discount for inactivity timeout for recording session length.

When session ends because of timeout we should subtract the
waiting time for more accurate session length.

BUG=645538
==========

[gayane -on leave until 09-2017, 2016-09-09 18:31:24]

Thanks.

https://codereview.chromium.org/2326723003/diff/60001/tools/metrics/histogram...
File tools/metrics/histograms/histograms.xml (right):

https://codereview.chromium.org/2326723003/diff/60001/tools/metrics/histogram...
tools/metrics/histograms/histograms.xml:54449: +    timeout.
On 2016/09/09 18:26:23, Alexei Svitkine (very slow) wrote:
> Nit: add "on desktop." to the end of the sentence.

Done.

[gayane -on leave until 09-2017, 2016-09-09 18:31:28]

The CQ bit was checked by gayane@chromium.org

[gayane -on leave until 09-2017, 2016-09-09 18:31:28]

The patchset sent to the CQ was uploaded after l-g-t-m from
asvitkine@chromium.org
Link to the patchset: https://codereview.chromium.org/2326723003/#ps80001
(title: "fix histogram description")

[commit-bot: I haz the power, 2016-09-09 18:32:30]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-09 19:40:36]

Description was changed from

==========
Discount for inactivity timeout for recording session length.

When session ends because of timeout we should subtract the
waiting time for more accurate session length.

BUG=645538
==========

to

==========
Discount for inactivity timeout for recording session length.

When session ends because of timeout we should subtract the
waiting time for more accurate session length.

BUG=645538
==========

[commit-bot: I haz the power, 2016-09-09 19:40:37]

Committed patchset #3 (id:80001)

[commit-bot: I haz the power, 2016-09-09 19:42:41]

Description was changed from

==========
Discount for inactivity timeout for recording session length.

When session ends because of timeout we should subtract the
waiting time for more accurate session length.

BUG=645538
==========

to

==========
Discount for inactivity timeout for recording session length.

When session ends because of timeout we should subtract the
waiting time for more accurate session length.

BUG=645538

Committed: https://crrev.com/f1abb8e62246a9514974aab9d0b547d570903ef9
Cr-Commit-Position: refs/heads/master@{#417672}
==========

[commit-bot: I haz the power, 2016-09-09 19:42:42]

Patchset 3 (id:??) landed as
https://crrev.com/f1abb8e62246a9514974aab9d0b547d570903ef9
Cr-Commit-Position: refs/heads/master@{#417672}