Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2326713002: GPU driver bug list: remove the use program after link workaround (Closed)

Created:
4 years, 3 months ago by Corentin Wallez
Modified:
4 years, 3 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

GPU driver bug list: remove the use program after link workaround The origins of this workaround go waaaaay in the past and seem to contradict themselves (only OSX, vs. not OSX) BUG=590870 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6 Cr-Commit-Position: refs/heads/master@{#417397}

Patch Set 1 #

Patch Set 2 : Update version #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -25 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M gpu/config/gpu_driver_bug_list_json.cc View 1 2 chunks +1 line, -21 lines 0 comments Download
M gpu/config/gpu_driver_bug_workaround_type.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
Corentin Wallez
PTAL, trying to remove this workaround from ANGLE at it seems not relevant anymore.
4 years, 3 months ago (2016-09-08 19:39:43 UTC) #3
Zhenyao Mo
On 2016/09/08 19:39:43, Corentin Wallez wrote: > PTAL, trying to remove this workaround from ANGLE ...
4 years, 3 months ago (2016-09-08 19:49:28 UTC) #4
Corentin Wallez
I'll watch the waterfall, thanks!
4 years, 3 months ago (2016-09-08 19:50:52 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326713002/1
4 years, 3 months ago (2016-09-08 19:51:21 UTC) #7
Corentin Wallez
On 2016/09/08 at 19:51:21, commit-bot wrote: > CQ is trying da patch. Follow status at ...
4 years, 3 months ago (2016-09-08 19:52:23 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326713002/20001
4 years, 3 months ago (2016-09-08 19:53:52 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-08 21:05:58 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/5d79fa21a0e1536b439584a8bce1f17fbc0c22b6 Cr-Commit-Position: refs/heads/master@{#417397}
4 years, 3 months ago (2016-09-08 21:08:29 UTC) #15
Corentin Wallez
4 years, 3 months ago (2016-09-09 17:15:31 UTC) #16
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2326553004/ by cwallez@chromium.org.

The reason for reverting is: Potential regression
https://bugs.chromium.org/p/chromium/issues/detail?id=645498.

Powered by Google App Engine
This is Rietveld 408576698