Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2326663002: Fix issues in assets scripts (Closed)

Created:
4 years, 3 months ago by borenet2
Modified:
4 years, 3 months ago
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Fix issues in assets scripts - Delete unconditionally uses 'gsutil' - args.gsutil not plumbed properly BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2326663002 Committed: https://skia.googlesource.com/skia/+/a42405aa522cd33292b9817da460e9f29e00a201

Patch Set 1 #

Patch Set 2 : Fix gsutil delete #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -6 lines) Patch
M infra/bots/assets/asset_utils.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M infra/bots/assets/assets.py View 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (12 generated)
borenet
4 years, 3 months ago (2016-09-08 18:17:54 UTC) #3
borenet
4 years, 3 months ago (2016-09-09 12:07:34 UTC) #7
rmistry
lgtm
4 years, 3 months ago (2016-09-09 12:08:45 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326663002/20001
4 years, 3 months ago (2016-09-09 12:36:35 UTC) #15
commit-bot: I haz the power
4 years, 3 months ago (2016-09-09 12:37:32 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/a42405aa522cd33292b9817da460e9f29e00a201

Powered by Google App Engine
This is Rietveld 408576698