Conditional hittesting & sending boundary events for captured pointer events

third_party/WebKit/Source/core/input/EventHandler.cpp

 /*
  * Copyright (C) 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2012 Digia Plc. and/or its subsidiary(-ies)
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 1366 matching lines @@
 
     return m_frame->document()->prepareMouseEvent(request, contentPointFromRootFrame(m_frame, mev.position()), mev);
 }
 
 Node* EventHandler::updateMouseEventTargetNode(Node* targetNode,
     const PlatformMouseEvent& mouseEvent)
 {
     Node* newNodeUnderMouse = targetNode;
 
     // If we're capturing, we always go right to that node.
-    if (EventTarget* mousePointerCapturingNode = m_pointerEventManager->getMouseCapturingNode()) {

[dtapuska, 2016/09/09 16:01:07]

I think it is cleaner to store the mousePointerCapturingNode in a variable
instead of calling it multiple times for ease of reading.

[Navid Zolghadr, 2016/09/09 16:03:38]

Then I have to store it outside the scope of the if which makes it defined for
the whole function scope. Is there a way to do it better?

+    if (m_pointerEventManager->getMouseCapturingNode()
+        && !RuntimeEnabledFeatures::pointerEventV1SpecCapturingEnabled()) {
+        EventTarget* mousePointerCapturingNode = m_pointerEventManager->getMouseCapturingNode();
         newNodeUnderMouse = mousePointerCapturingNode->toNode();
         DCHECK(newNodeUnderMouse);
     } else if (m_capturingMouseEventsNode) {
         newNodeUnderMouse = m_capturingMouseEventsNode.get();
     } else {
         // If the target node is a text node, dispatch on the parent node - rdar://4196646
         if (newNodeUnderMouse && newNodeUnderMouse->isTextNode())
             newNodeUnderMouse = FlatTreeTraversal::parent(*newNodeUnderMouse);
     }
     Node* lastNodeUnderMouse = m_nodeUnderMouse;
@@ skipping 1160 matching lines @@
 
 FrameHost* EventHandler::frameHost() const
 {
     if (!m_frame->page())
         return nullptr;
 
     return &m_frame->page()->frameHost();
 }
 
 } // namespace blink