Use monotonic time instead of current time in autoscroll controller

Use monotonic time instead of current time in autoscroll controller
Use of a wall clock to drive an animation is dangerous. We should be using the monotinic time.

BUG=645098
Committed: https://crrev.com/7d69521b65cd8d03eabe16411c7198dd1520d382
Cr-Commit-Position: refs/heads/master@{#417365}

[sunyunjia, 2016-09-08 17:58:20]

The CQ bit was checked by sunyunjia@chromium.org to run a CQ dry run

[sunyunjia, 2016-09-08 17:58:40]

Description was changed from

==========
Use monotonic time instead of current time in autoscroll controller
Use of a wall clock to drive an animation is dangerous. We should be using the
monotinic time.

BUG=645098
==========

to

==========
Use monotonic time instead of current time in autoscroll controller
Use of a wall clock to drive an animation is dangerous. We should be using the
monotinic time.

BUG=645098
==========

[sunyunjia, 2016-09-08 17:58:40]

sunyunjia@chromium.org changed reviewers:
+ bokan@chromium.org, dtapuska@chromium.org

[commit-bot: I haz the power, 2016-09-08 17:58:49]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sunyunjia, 2016-09-08 17:59:24]

PTAL. Thanks!

[dtapuska, 2016-09-08 18:09:52]

https://codereview.chromium.org/2326643002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/AutoscrollController.cpp (right):

https://codereview.chromium.org/2326643002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/AutoscrollController.cpp:245: if
(WTF::monotonicallyIncreasingTime() - m_dragAndDropAutoscrollStartTime >
autoscrollDelay)
You are going to have to adjust the initialization of the
m_dragAndDropAutoscrollStartTime because they are a different clock base (start
time).

[dtapuska, 2016-09-08 18:16:27]

lgtm

https://codereview.chromium.org/2326643002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/page/AutoscrollController.cpp (right):

https://codereview.chromium.org/2326643002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/page/AutoscrollController.cpp:245: if
(WTF::monotonicallyIncreasingTime() - m_dragAndDropAutoscrollStartTime >
autoscrollDelay)
On 2016/09/08 18:09:51, dtapuska wrote:
> You are going to have to adjust the initialization of the
> m_dragAndDropAutoscrollStartTime because they are a different clock base
(start
> time).

Nevermind it appears that the m_dragAndDropAutoscrollStartTime is coming from
the event timestamp which is monotonic already.

[bokan, 2016-09-08 18:16:52]

lgtm

[commit-bot: I haz the power, 2016-09-08 19:33:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:33:20]

Dry run: This issue passed the CQ dry run.

[sunyunjia, 2016-09-08 19:34:44]

The CQ bit was checked by sunyunjia@chromium.org

[commit-bot: I haz the power, 2016-09-08 19:35:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-08 19:39:58]

Description was changed from

==========
Use monotonic time instead of current time in autoscroll controller
Use of a wall clock to drive an animation is dangerous. We should be using the
monotinic time.

BUG=645098
==========

to

==========
Use monotonic time instead of current time in autoscroll controller
Use of a wall clock to drive an animation is dangerous. We should be using the
monotinic time.

BUG=645098
==========

[commit-bot: I haz the power, 2016-09-08 19:40:00]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-09-08 19:42:10]

Description was changed from

==========
Use monotonic time instead of current time in autoscroll controller
Use of a wall clock to drive an animation is dangerous. We should be using the
monotinic time.

BUG=645098
==========

to

==========
Use monotonic time instead of current time in autoscroll controller
Use of a wall clock to drive an animation is dangerous. We should be using the
monotinic time.

BUG=645098

Committed: https://crrev.com/7d69521b65cd8d03eabe16411c7198dd1520d382
Cr-Commit-Position: refs/heads/master@{#417365}
==========

[commit-bot: I haz the power, 2016-09-08 19:42:11]

Patchset 1 (id:??) landed as
https://crrev.com/7d69521b65cd8d03eabe16411c7198dd1520d382
Cr-Commit-Position: refs/heads/master@{#417365}