third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h - Issue 2326633002: Adds filter support for offscreen canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h

Issue 2326633002: Adds filter support for offscreen canvas (Closed)

Patch Set: New version without StyleResolver Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp ('K') | « third_party/WebKit/Source/core/css/resolver/StyleBuilderConverter.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp » ('j') | third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h

index 24fc2257d7d74d187c62d6097fc3e3b7bf28753b..f8a821a1daed0f4eb7d96667ded2c13e00b49e2b 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasRenderingContext2DState.h

@@ -95,6 +95,8 @@ class CanvasRenderingContext2DState final

SkImageFilter* getFilter(Element*,

IntSize canvasSize,

CanvasRenderingContext2D*) const;

+ SkImageFilter* getFilterWithoutDocument(IntSize canvasSize) const;

Justin Novosad 2016/10/24 18:51:22 I'd rather this be called getFilterForOffscreenCan

fserb 2016/10/26 19:08:26 done

+ bool hasFilterWithoutDocument(IntSize canvasSize) const;

Justin Novosad 2016/10/24 18:51:22 same here.

fserb 2016/10/26 19:08:26 done

bool hasFilter(Element*, IntSize canvasSize, CanvasRenderingContext2D*) const;

void clearResolvedFilter() const;