third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp - Issue 2326633002: Adds filter support for offscreen canvas

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

Issue 2326633002: Adds filter support for offscreen canvas (Closed)

Patch Set: Working version of filters on offscreen canvas Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp ('K') | « third_party/WebKit/Source/core/css/resolver/ElementStyleResources.cpp ('k') | third_party/WebKit/Source/core/css/resolver/FontBuilder.h » ('j') | third_party/WebKit/Source/core/css/resolver/FontBuilder.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

diff --git a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

index ade326092eb9962e4192c6c27797ed21162f9d0c..2f43fc5a443e052d5d86380bdcc60b6746cd7746 100644

--- a/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

+++ b/third_party/WebKit/Source/core/css/resolver/FilterOperationResolver.cpp

@@ -128,7 +128,8 @@ FilterOperations FilterOperationResolver::createFilterOperations(StyleResolverSt

const CSSToLengthConversionData& conversionData = state.cssToLengthConversionData();

for (auto& currValue : toCSSValueList(inValue)) {

if (currValue->isURIValue()) {

- countFilterUse(FilterOperation::REFERENCE, state.document());

+ if (state.hasDocument())

+ countFilterUse(FilterOperation::REFERENCE, state.document());

const CSSURIValue& urlValue = toCSSURIValue(*currValue);

SVGURLReferenceResolver resolver(urlValue.value(), state.document());

@@ -145,7 +146,8 @@ FilterOperations FilterOperationResolver::createFilterOperations(StyleResolverSt

const CSSFunctionValue* filterValue = toCSSFunctionValue(currValue.get());

FilterOperation::OperationType operationType = filterOperationForType(filterValue->functionType());

- countFilterUse(operationType, state.document());

+ if (state.hasDocument())

+ countFilterUse(operationType, state.document());

DCHECK_LE(filterValue->length(), 1u);

const CSSPrimitiveValue* firstValue = filterValue->length() && filterValue->item(0).isPrimitiveValue() ? &toCSSPrimitiveValue(filterValue->item(0)) : nullptr;