Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Unified Diff: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h

Issue 2326633002: Adds filter support for offscreen canvas (Closed)
Patch Set: Added more tests, added CSS color identifiers Created 3 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
diff --git a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
index aea21e293d88f20e0f64b602e72cde3ff95b3baf..c34d1169de2ff795765f56633b1c21409b919d14 100644
--- a/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
+++ b/third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h
@@ -44,8 +44,8 @@ class MODULES_EXPORT OffscreenCanvasRenderingContext2D final
ContextType getContextType() const override { return Context2d; }
bool is2d() const override { return true; }
void setOffscreenCanvasGetContextResult(OffscreenRenderingContext&) final;
- void setIsHidden(bool) final { ASSERT_NOT_REACHED(); }
- void stop() final { ASSERT_NOT_REACHED(); }
+ void setIsHidden(bool) final { NOTREACHED(); }
+ void stop() final { NOTREACHED(); }
void setCanvasGetContextResult(RenderingContext&) final {}
void clearRect(double x, double y, double width, double height) override {
BaseRenderingContext2D::clearRect(x, y, width, height);
@@ -77,6 +77,7 @@ class MODULES_EXPORT OffscreenCanvasRenderingContext2D final
bool stateHasFilter() final;
sk_sp<SkImageFilter> stateGetFilter() final;
void snapshotStateForFilter() final {}
+ void setFilter(const String&);
Justin Novosad 2017/01/17 21:59:47 I see no definition for this new method.
fserb 2017/01/17 22:10:42 wait. Is this a tricky question? It's right there,
void validateStateStack() const final;

Powered by Google App Engine
This is Rietveld 408576698