Issue 232663002: Password manager internals page: clean-up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 232663002: Password manager internals page: clean-up (Closed)

Created:
6 years, 8 months ago by vabr (Chromium)

Modified:
6 years, 8 months ago

Reviewers:
Mike West

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Password manager internals page: clean-up Two little fixes which did not fit in any of the major CLs for the internals page. BUG=347927 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=262971

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -3 lines)			Patch
	M	components/password_manager/core/browser/browser_save_password_progress_logger_unittest.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
	M	components/password_manager/core/browser/password_manager_unittest.cc	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 5 (0 generated)

vabr (Chromium)

Mike, Would you mind a short review for me? Thanks! Vaclav

6 years, 8 months ago (2014-04-10 07:52:31 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vabr@chromium.org/232663002/1

6 years, 8 months ago (2014-04-10 08:15:55 UTC) #4

Message was sent while issue was closed.

Change committed as 262971