chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc - Issue 2326623003: Make SystemMonitor report all audio device changes instead of just audio capture.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

Issue 2326623003: Make SystemMonitor report all audio device changes instead of just audio capture. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc ('k') | chromeos/audio/cras_audio_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

diff --git a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

index ae03b542f43ed883b70a30d068a9ae6441a64c71..8c3c475fc6585c7423fd89f2d44e196e5e0dde52 100644

--- a/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

+++ b/chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc

@@ -377,12 +377,12 @@ IN_PROC_BROWSER_TEST_F(WebrtcAudioPrivateTest, MAYBE_TriggerEvent) {

WebrtcAudioPrivateEventService::GetFactoryInstance()->Get(profile());

// Just trigger, without any extension listening.

- service->OnDevicesChanged(base::SystemMonitor::DEVTYPE_AUDIO_CAPTURE);

+ service->OnDevicesChanged(base::SystemMonitor::DEVTYPE_AUDIO);

// Now load our test extension and do it again.

const extensions::Extension* extension = LoadExtension(

test_data_dir_.AppendASCII("webrtc_audio_private_event_listener"));

- service->OnDevicesChanged(base::SystemMonitor::DEVTYPE_AUDIO_CAPTURE);

+ service->OnDevicesChanged(base::SystemMonitor::DEVTYPE_AUDIO);

// Check that the extension got the notification.

std::string result = ExecuteScriptInBackgroundPage(extension->id(),