Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 2326623003: Make SystemMonitor report all audio device changes instead of just audio capture. (Closed)

Created:
4 years, 3 months ago by Guido Urdaneta
Modified:
4 years, 3 months ago
CC:
chromium-apps-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, extensions-reviews_chromium.org, feature-media-reviews_chromium.org, jam, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, oshima+watch_chromium.org, posciak+watch_chromium.org, toyoshim+midi_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make SystemMonitor report all audio device changes instead of just audio capture. Linux and Windows were already reporting audio output device changes as DEVTYPE_AUDIO_CAPTURE. This CL basically renames DEVTYPE_AUDIO_CAPTURE to DEVTYPE_AUDIO and makes the CrOS device monitor to report audio-output device changes in addition to audio-capture devices. The only platform that needs further work is Mac, which currently does not report device changes for output-only devices such as USB speakers. BUG=587396 Committed: https://crrev.com/d6789a38d48d6e5fcf4703a1cbf7d1525706b082 Cr-Commit-Position: refs/heads/master@{#419136}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M base/system_monitor/system_monitor.h View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/webrtc_audio_private/webrtc_audio_private_browsertest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chromeos/audio/cras_audio_handler.cc View 1 chunk +7 lines, -9 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager_unittest.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M media/audio/win/audio_device_listener_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/device_monitors/device_monitor_mac.mm View 1 chunk +1 line, -1 line 0 comments Download
M media/device_monitors/device_monitor_udev.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/device_monitors/system_message_window_win.cc View 1 chunk +1 line, -1 line 0 comments Download
M media/midi/midi_manager_win.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 34 (19 generated)
Guido Urdaneta
jennyz@chromium.org: Please review changes in chromeos/ audio dcheng@chromium.org: Please review changes in base/ tommi@chromium.org: Please ...
4 years, 3 months ago (2016-09-09 16:54:22 UTC) #6
DaleCurtis
If this is just a name change, media/ lgtm
4 years, 3 months ago (2016-09-09 17:36:58 UTC) #7
Guido Urdaneta
On 2016/09/09 17:36:58, DaleCurtis wrote: > If this is just a name change, media/ lgtm ...
4 years, 3 months ago (2016-09-09 17:38:44 UTC) #8
dcheng
rs lgtm for //base
4 years, 3 months ago (2016-09-09 18:41:42 UTC) #11
tommi (sloooow) - chröme
lgtm
4 years, 3 months ago (2016-09-09 18:49:50 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326623003/20001
4 years, 3 months ago (2016-09-09 18:50:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/256712)
4 years, 3 months ago (2016-09-09 18:56:34 UTC) #16
Guido Urdaneta
steel@chromium.org: please review changes in chromeos/audio lazyboy@chromium.org: please review changes in chrome/browser/extensions
4 years, 3 months ago (2016-09-13 10:13:12 UTC) #20
lazyboy
chrome/browser/extensions/* lgtm.
4 years, 3 months ago (2016-09-13 18:56:29 UTC) #21
Rahul Chaturvedi
Adding Jenny for audio review. I'll be removing myself from OWNERs for audio, it has ...
4 years, 3 months ago (2016-09-13 21:44:33 UTC) #23
Guido Urdaneta
hshi@: can you also take a look at chromos/audio?
4 years, 3 months ago (2016-09-15 09:25:33 UTC) #25
jennyz
lgtm
4 years, 3 months ago (2016-09-15 21:26:45 UTC) #26
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2326623003/20001
4 years, 3 months ago (2016-09-16 08:11:43 UTC) #28
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 3 months ago (2016-09-16 09:29:41 UTC) #30
commit-bot: I haz the power
4 years, 3 months ago (2016-09-16 09:31:13 UTC) #32
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d6789a38d48d6e5fcf4703a1cbf7d1525706b082
Cr-Commit-Position: refs/heads/master@{#419136}

Powered by Google App Engine
This is Rietveld 408576698